Skip to content

directly read into buffer #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Disservin merged 2 commits into from
Sep 30, 2025
Merged

directly read into buffer #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f1c0ca
directly read into buffer
Disservin Sep 30, 2025
95fb32b
update
Disservin Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/compressed_training_file_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,14 @@ impl<T: Read + Seek> CompressedTrainingDataFileReader<T> {
Ok(data)
}

pub fn read_next_chunk_into(&mut self, buffer: &mut Vec<u8>) -> Result<()> {
let header = self.read_chunk_header()?;
buffer.resize(header.chunk_size as usize, 0);
self.file.read_exact(buffer)?;
self.read_bytes += header.chunk_size as u64;
Ok(())
}

fn read_chunk_header(&mut self) -> Result<Header> {
let mut buf = [0u8; HEADER_SIZE];

Expand Down
9 changes: 5 additions & 4 deletions src/reader/compressed_reader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,11 @@ impl<T: Read + Seek> CompressedTrainingDataEntryReader<T> {
reader.is_end = true;
return Err(CompressedReaderError::EndOfFile);
} else {
reader.chunk = match reader.input_file.as_mut().unwrap().read_next_chunk() {
Ok(chunk) => chunk,
Err(e) => return Err(CompressedReaderError::BinpackError(e)),
};
reader
.input_file
.as_mut()
.unwrap()
.read_next_chunk_into(&mut reader.chunk)?;
}

Ok(reader)
Expand Down