Update src/PyListProxyHandler.cc

philippedistributive · zollqir · web-flow · commit a5dfe1b0ff6e · 2024-04-22T12:27:48.000-04:00
Co-authored-by: Caleb Aikens &lt;caleb@distributive.network&gt;
diff --git a/src/PyListProxyHandler.cc b/src/PyListProxyHandler.cc
@@ -164,9 +164,12 @@ static bool array_unshift(JSContext *cx, unsigned argc, JS::Value *vp) { // sure
   JS::RootedValue elementVal(cx);
   for (int index = args.length() - 1; index >= 0; index--) {
     elementVal.set(args[index].get());
-    if (PyList_Insert(self, 0, pyTypeFactory(cx, elementVal)) < 0) {
+    PyObject *value = pyTypeFactory(cx, elementVal);
+    if (PyList_Insert(self, 0, value) < 0) {
+      Py_DECREF(value);
       return false;
     }
+    Py_DECREF(value);
   }
 
   args.rval().setInt32(PyList_GET_SIZE(self));

Original file line number	Diff line number	Diff line change
`@@ -164,9 +164,12 @@ static bool array_unshift(JSContext cx, unsigned argc, JS::Value vp) { // sure`
`164`	`164`	`JS::RootedValue elementVal(cx);`
`165`	`165`	`for (int index = args.length() - 1; index >= 0; index--) {`
`166`	`166`	`elementVal.set(args[index].get());`
`167`		`- if (PyList_Insert(self, 0, pyTypeFactory(cx, elementVal)) < 0) {`
	`167`	`+ PyObject *value = pyTypeFactory(cx, elementVal);`
	`168`	`+ if (PyList_Insert(self, 0, value) < 0) {`
	`169`	`+ Py_DECREF(value);`
`168`	`170`	`return false;`
`169`	`171`	`}`
	`172`	`+ Py_DECREF(value);`
`170`	`173`	`}`
`171`	`174`
`172`	`175`	`args.rval().setInt32(PyList_GET_SIZE(self));`