Skip to content

Commit b4a40c2

Browse files
committed
fixup(CI): remove core dumps as CI artifacts
core dumps cannot be read in a container
1 parent afdced2 commit b4a40c2

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

.github/workflows/test-and-publish.yaml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -249,20 +249,12 @@ jobs:
249249
path: ./dist/
250250
- name: Run Python tests (pytest)
251251
run: |
252-
if [[ "$OSTYPE" == "linux-gnu"* || "$OSTYPE" == "darwin"* ]]; then
253-
# TODO (Caleb Aikens) figure out how to get Windows core dumps
254-
ulimit -c unlimited
255-
fi
256252
WORKFLOW_BUILD_TYPE=${{ inputs.build_type }}
257253
BUILD_TYPE=${WORKFLOW_BUILD_TYPE:-"Debug"} poetry run python -m pip install --force-reinstall --verbose ./dist/*
258254
poetry run python -m pytest tests/python
259255
- name: Run JS tests (peter-jr)
260256
if: ${{ (success() || failure()) }}
261257
run: |
262-
if [[ "$OSTYPE" == "linux-gnu"* || "$OSTYPE" == "darwin"* ]]; then
263-
# TODO (Caleb Aikens) figure out how to get Windows core dumps
264-
ulimit -c unlimited
265-
fi
266258
poetry run bash ./peter-jr ./tests/js/
267259
- name: SSH debug session
268260
if: ${{ (success() || failure()) && github.event_name == 'workflow_dispatch' && inputs.debug_enabled_os == matrix.os && inputs.debug_enabled_python == matrix.python_version}}

0 commit comments

Comments
 (0)