Make the wheel packages we build also support lower versions of macOS #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f macOS, otherwise pip would fallback to compile from source Change the platform tag part of the wheel filename to `macosx_11_xxx` (means to support macOS 11). A wheel package file will only be selected by pip to install if the platform tag satisfies, regardless of whether the binary compatibility actually is. See https://packaging.python.org/en/latest/specifications/binary-distribution-format/#file-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise pip would fallback to compile from source.
A wheel package file will only be selected by pip to install if the platform tag satisfies, regardless of whether the binary compatibility actually is.
The wheel package we build for arm64 is currently named
pythonmonkey-0.x.x-cp310-cp310-macosx_14_0_arm64.whl. According to https://packaging.python.org/en/latest/specifications/binary-distribution-format/#file-format and https://packaging.python.org/en/latest/specifications/platform-compatibility-tags/, its platform tag ismacosx_14_0_arm64, meaning it will only be selected by pip to install on macOS version 14.0 and above, regardless of whether the binary compatibility actually is.If there's no binary compatibility issue (like we saw on Ubuntu about the glibc versions) on macOS, renaming the file to something like
pythonmonkey-0.x.x-cp310-cp310-macosx_11_0_arm64.whlwill let pip to install a prebuilt version of pythonmonkey rather than build from source.