Fix warning on ActiveSupport::Cache.format_version #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rail.application` was always evaluating to `nil` before as the code wasn't running in an initializer. As a fix, instead simply provide a non-deprecated serializer to the initialized cache_store when in test environment (and where the code would raise a warning otherwise). Also move this block to a proper Rails initializer.
DmitryTsepelev
approved these changes
Oct 19, 2024
Owner
DmitryTsepelev
left a comment
DmitryTsepelev
left a comment
There was a problem hiding this comment.
LGTM, let's try it out 🙂
r7kamura
added a commit
to r7kamura/graphql-ruby-fragment_cache
that referenced
this pull request
Oct 28, 2024
DmitryTsepelev
pushed a commit
that referenced
this pull request
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
Rail.applicationwas always evaluating tonilbefore as the code wasn't running in an initializer.I changed the approach slightly to be less intrusive: now we simply initialize the cache store with a non-deprecated serializer, instead of modifying the
ActiveSupport.cache_format_versionconfiguration.NOTE: after my change, if the user is on Rails >= 7 and didn't configure
ActiveSupport::Cache.format_version, if they manually change the store (e.g.:Rails.application.config.graphql_fragment_cache = :memory_store), that will raise a ActiveSupport warning.I believe this behaviour is appropriate - the user should set an appropriate cache_format_version before setting the cache store.