Remove hardcoded tub fields and silent fallbacks from TubStatistics#24
Merged
DocGarbanzo merged 3 commits intodevfrom Jan 27, 2026
Merged
Conversation
- Remove deprecated gyro_z_index parameter from TubStatistics.__init__ - Require explicit field_aggregations or config with FIELD_AGGREGATIONS - Remove silent gyro_z_agg fallback in default_lap_sorting_strategy - Update _load_field_aggregations_from_config to require FIELD_AGGREGATIONS - Raise ValueError for old-style field_aggregations with 'extractor' - Update all tests to pass explicit field_aggregations parameter - Add FULL_SORTING_STRATEGY helper for tests that need gyro_z_agg ranking This ensures all tub field configurations are explicit - no silent defaults that may not match the actual tub schema. https://claude.ai/code/session_01BkSETqkmCyc5PavsvyAidf
- Add FIELD_AGGREGATIONS to test configs that use TubDataset with config - Add LAP_SORTING_CRITERIA to test configs that expect gyro_z_agg rankings - Add FULL_SORTING_STRATEGY constant to tests that need gyro_z_agg in rankings - Update tests to pass explicit sorting_strategy when testing gyro_z_agg These tests previously relied on silent defaults that have been removed. https://claude.ai/code/session_01BkSETqkmCyc5PavsvyAidf
Add skipif markers to tests that depend on external tub data at /Users/dirk/cars/hyper/data. These tests will now skip gracefully when the data directory or catalog manifest files don't exist. https://claude.ai/code/session_01BkSETqkmCyc5PavsvyAidf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures all tub field configurations are explicit - no silent defaults
that may not match the actual tub schema.
https://claude.ai/code/session_01BkSETqkmCyc5PavsvyAidf