-
Notifications
You must be signed in to change notification settings - Fork 22
Fix content type construction parameter issue 128 #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vsouz4
merged 4 commits into
master
from
fix-content-type-construction-parameter-issue-128
Dec 9, 2025
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7259326
Fixed issue #128 - Fixed content type construction parameter generation.
Dressi ae01da0
Fixed issue #128 - Fixed content type construction parameter generation.
Dressi a1ea413
Merge remote-tracking branch 'origin/fix-content-type-construction-pa…
Dressi efbdcef
Fixed issue #128 - Fixed content type construction parameter generation.
Dressi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
test/suite/functional/Generator/Request/GetResourceByTypeRequest83.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /* | ||
| * This file was generated by docler-labs/api-client-generator. | ||
| * | ||
| * Do not edit it manually. | ||
| */ | ||
|
|
||
| namespace Test\Request; | ||
|
|
||
| use Test\Schema\ResourceTypeEnum; | ||
|
|
||
| class GetResourceByTypeRequest implements RequestInterface | ||
| { | ||
| private string $contentType = ''; | ||
|
|
||
| public function __construct(private readonly ResourceTypeEnum $resourceType) | ||
| { | ||
| } | ||
|
|
||
| public function getContentType(): string | ||
| { | ||
| return $this->contentType; | ||
| } | ||
|
|
||
| public function getMethod(): string | ||
| { | ||
| return 'GET'; | ||
| } | ||
|
|
||
| public function getRoute(): string | ||
| { | ||
| return strtr('v1/{resource-type}/resource', ['{resource-type}' => $this->resourceType->value]); | ||
| } | ||
|
|
||
| public function getQueryParameters(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getRawQueryParameters(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getCookies(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getHeaders(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getBody() | ||
| { | ||
| return null; | ||
| } | ||
| } |
106 changes: 106 additions & 0 deletions
106
test/suite/functional/Generator/Request/GetResourcesRequest83.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| /* | ||
| * This file was generated by docler-labs/api-client-generator. | ||
| * | ||
| * Do not edit it manually. | ||
| */ | ||
|
|
||
| namespace Test\Request; | ||
|
|
||
| use Test\Schema\ResourceFilter; | ||
| use Test\Schema\SerializableInterface; | ||
|
|
||
| class GetResourcesRequest implements RequestInterface | ||
| { | ||
| private ?int $filterById = null; | ||
|
|
||
| private ?string $filterByName = null; | ||
|
|
||
| private ?array $filterByIds = null; | ||
|
|
||
| private ?ResourceFilter $filter = null; | ||
|
|
||
| private string $contentType = ''; | ||
|
|
||
| public function __construct(private readonly AuthenticationCredentials $credentials) | ||
| { | ||
| } | ||
|
|
||
| public function getContentType(): string | ||
| { | ||
| return $this->contentType; | ||
| } | ||
|
|
||
| public function setFilterById(int $filterById): self | ||
| { | ||
| $this->filterById = $filterById; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function setFilterByName(string $filterByName): self | ||
| { | ||
| $this->filterByName = $filterByName; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| /** | ||
| * @param int[] $filterByIds | ||
| */ | ||
| public function setFilterByIds(array $filterByIds): self | ||
| { | ||
| $this->filterByIds = $filterByIds; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function setFilter(ResourceFilter $filter): self | ||
| { | ||
| $this->filter = $filter; | ||
|
|
||
| return $this; | ||
| } | ||
|
|
||
| public function getMethod(): string | ||
| { | ||
| return 'GET'; | ||
| } | ||
|
|
||
| public function getRoute(): string | ||
| { | ||
| return 'v1/resources'; | ||
| } | ||
|
|
||
| public function getQueryParameters(): array | ||
| { | ||
| return array_map(static function ($value) { | ||
| return $value instanceof SerializableInterface ? $value->toArray() : $value; | ||
| }, array_filter(['filterById' => $this->filterById, 'filterByName' => $this->filterByName, 'filterByIds' => $this->filterByIds, 'filter' => $this->filter], static function ($value) { | ||
| return null !== $value; | ||
| })); | ||
| } | ||
|
|
||
| public function getRawQueryParameters(): array | ||
| { | ||
| return ['filterById' => $this->filterById, 'filterByName' => $this->filterByName, 'filterByIds' => $this->filterByIds, 'filter' => $this->filter]; | ||
| } | ||
|
|
||
| public function getCookies(): array | ||
| { | ||
| return []; | ||
| } | ||
|
|
||
| public function getHeaders(): array | ||
| { | ||
| return ['Authorization' => sprintf('Basic %s', base64_encode(sprintf('%s:%s', $this->credentials->getUsername(), $this->credentials->getPassword())))]; | ||
| } | ||
|
|
||
| public function getBody() | ||
| { | ||
| return null; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these constants used anywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not from the Client. I extended the example with ContentType header enum and test run re-generated this example.
As I see these constants consumers. From PHP 8.1 it's not generated, becasue the enum class is used.