fix: Global install by making lefthook setup conditional#30
Merged
Conversation
The prepare script was failing when installing via npm install -g because lefthook tried to set up git hooks in non-git directories. Changes: - Created scripts/prepare.js that checks for .git before running lefthook - Script gracefully skips hook setup in CI and non-git environments - Updated README with simple npm install -g command - Fixes issue where global install would fail with lefthook error 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
amix
changed the title
![doist-bot[bot]](https://avatars.githubusercontent.com/in/2345791?s=60&v=4){kind=small}
`CI=1` and other truthy values are now caught, not just `CI=true`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnapse
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes global install failure when running
npm install -g github:Doist/outline-cliProblem
The
preparescript unconditionally ranlefthook install, which failed during global installs (npm creates a temp directory without.git) and whenlefthookisn't available globally.Solution
Created
scripts/prepare.jsthat:Updated README with simpler install instructions.
Testing
npm install -g .succeedsolcommand works correctly after install