Skip to content

Comments

chore: Update React development guidelines#1014

Merged
scottlovegrove merged 1 commit intomainfrom
sync-react-guidelines-1771602422
Feb 20, 2026
Merged

chore: Update React development guidelines#1014
scottlovegrove merged 1 commit intomainfrom
sync-react-guidelines-1771602422

Conversation

@doistbot
Copy link
Member

This PR updates docs/react-guidelines with the latest version from the shared-configs repository.

Changes

This is an automated sync of the shared React development guidelines configuration.

Source

Doist/shared-configs/


🤖 This PR was automatically created by the shared-configs sync workflow.

This file is automatically synced from the `shared-configs` repository.

Source: https://github.com/doist/shared-configs/blob/main/
@doistbot doistbot requested review from a team and scottlovegrove and removed request for a team February 20, 2026 15:47
@scottlovegrove scottlovegrove merged commit 3485a1f into main Feb 20, 2026
6 checks passed
@scottlovegrove scottlovegrove deleted the sync-react-guidelines-1771602422 branch February 20, 2026 15:49
Copy link

@doist-bot doist-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This automated update keeps our React development guidelines in sync with the latest shared configurations, ensuring consistent documentation and best practices across the codebase. While these improvements help maintain alignment with our standards, the section on Zustand middleware currently references an incorrect import path for the immer middleware that would result in a module resolution error.

Share FeedbackReview Logs


```typescript
import { create } from 'zustand'
import { devtools, immer } from 'zustand/middleware'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Incorrect import path for Zustand immer middleware

The immer middleware is exported from zustand/middleware/immer, not zustand/middleware. The zustand/middleware entry point exports devtools, persist, subscribeWithSelector, combine, and redux, but not immer. This import would fail at build time with a module resolution error. Per the official Zustand docs, the correct imports are:

Suggested change
import { devtools, immer } from 'zustand/middleware'
import { devtools } from 'zustand/middleware'
import { immer } from 'zustand/middleware/immer'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants