Conversation
4acb7ad to
565dc9b
Compare
There was a problem hiding this comment.
This PR introduces a helpful new tw conversation with <user-ref> command for quickly looking up 1:1 and group conversations, complete with solid test coverage and updated documentation. Reusing the existing conversation view output is a great approach that keeps the CLI consistent. A couple of minor adjustments are noted regarding the JSON and NDJSON formatters to ensure the --full flag is properly respected by passing the correct 'conversation' entity type.
2451bec to
4616609
Compare
4616609 to
b2af243
Compare
There was a problem hiding this comment.
This PR introduces a helpful new tw conversation with command for easily locating 1:1 and group conversations, complete with robust ambiguity handling and test coverage. The addition provides great utility and improves the CLI's overall workflow for finding specific DMs. There is just one minor inconsistency noted regarding the --full flag, which currently acts as a no-op due to missing entity types in the JSON formatting calls and should be adjusted to properly filter or expand the output.
rfgamaral
left a comment
There was a problem hiding this comment.
Great addition 👏 (just left a few comments for your consideration)
| } catch (error) { | ||
| console.error((error as Error).message) | ||
| process.exit(1) | ||
| } |
There was a problem hiding this comment.
Other command handlers in this file let errors propagate rather than catching and calling process.exit(1). Should this follow the same pattern for consistency? 🤔
There was a problem hiding this comment.
I’d keep the local catch for now. This command hit a real UX issue without it: lookup failures like ambiguous user refs bubbled up as a noisy exception trace. If we want consistency here, I think the right fix is a top-level error handler in src/index.ts, then we can remove ad hoc console.error(...); process.exit(1) patterns across commands in one pass. But I'd rather not do that here.
d13bfd9 to
7193054
Compare
# [2.9.0](v2.8.0...v2.9.0) (2026-03-11) ### Features * add conversation lookup by user ([#76](#76)) ([50ebe3b](50ebe3b))
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds a new
tw conversation with <user-ref>command to find your exact 1:1 DM with a user.The command also supports
--include-groupsto list any matching group conversations, pages throughconversations/getso older DMs are found, and prints clean ambiguity errors without a stack trace while still exiting non-zero. By default it shows a compact conversation summary, and--snippetopts into the latest message preview.Tests were added for the new resolution flow, including older paged conversations, and the Twist CLI skill content was updated to document the new command.