Merged
Conversation
Contributor
Author
|
@Siumauricio |
Contributor
|
The project currently uses |
Contributor
Author
|
@vishalkadam47 I will install Biome, and remove the prettier dependency but my point on formatting style is still valid |
Contributor
|
Add in this PR #1578 an autofix to always format the code correctly. |
Siumauricio
requested changes
Mar 29, 2025
Contributor
Author
|
I still believe that the current formatting using tabs makes code review, at least here on github on a normal screen nearly imposible. |
Siumauricio
approved these changes
Mar 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added prettier to the project dev dependencies, tried to match current style in the .prettierrc config
added prettier tailwind plugin too
Refactored the ShowBuildChooseForm component to:
Extract duplicated form reset logic into a helper function (resetData)
Use a mapping for rendering the radio group items from the BuildType enum
buildTypeDisplayMap based on BuildType for Labels
Tested locally and confirmed that the form state updates correctly.