Skip to content

Conversation

@TheoD02
Copy link
Contributor

@TheoD02 TheoD02 commented Apr 2, 2025

Fix #1612

@TheoD02 TheoD02 requested a review from Siumauricio as a code owner April 2, 2025 20:29
@Siumauricio
Copy link
Contributor

Did you tested this @TheoD02 ?

I tried to run but It never deploy when I push on git tag

Can you add a video testing this?

@TheoD02
Copy link
Contributor Author

TheoD02 commented Apr 13, 2025

Did you tested this @TheoD02 ?

No sorry, I haven’t tested it yet.
I couldn’t manage to connect GitHub locally, I’ll try again

If you have any guidance, I’d be happy to take it, Thanks

@Siumauricio
Copy link
Contributor

@TheoD02 you can use a service like ngrok or something similar, and then expose the port where the application is running for example with ngrok ngrok http 3000 and then you can receive webhooks from github

@TheoD02
Copy link
Contributor Author

TheoD02 commented Apr 21, 2025

@TheoD02 you can use a service like ngrok or something similar, and then expose the port where the application is running for example with ngrok ngrok http 3000 and then you can receive webhooks from github

Hello, thanks for the indication, just tested and fixed, and all is working fine 👌 let you retest on your side

CleanShot 2025-04-21 at 02 24 58@2x (Deploy error is because my image build fail, but trigger is OK)

…n definitions and replace with ENUM type in application and compose tables. Update shared schema to include triggerType enum.
…or deployment triggers (push/tag) and update form handling in SaveGithubProvider and SaveGithubProviderCompose components.
…n SaveGithubProvider and SaveGithubProviderCompose components.
@Siumauricio Siumauricio merged commit 7ae3ff2 into Dokploy:canary Apr 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support deploy on git tag

2 participants