-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat(github): add triggerType field to GitHub provider and handle tag creation events #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Did you tested this @TheoD02 ? I tried to run but It never deploy when I push on git tag Can you add a video testing this? |
No sorry, I haven’t tested it yet. If you have any guidance, I’d be happy to take it, Thanks |
|
@TheoD02 you can use a service like ngrok or something similar, and then expose the port where the application is running for example with ngrok |
Hello, thanks for the indication, just tested and fixed, and all is working fine 👌 let you retest on your side
|
…n definitions and replace with ENUM type in application and compose tables. Update shared schema to include triggerType enum.
…or deployment triggers (push/tag) and update form handling in SaveGithubProvider and SaveGithubProviderCompose components.
…y removing fallback to login name.
…n SaveGithubProvider and SaveGithubProviderCompose components.

Fix #1612