feat: add support for a system theme #3163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siumauricio
requested changes
Dec 8, 2025
Contributor
Siumauricio
left a comment
Siumauricio
left a comment
There was a problem hiding this comment.
This has a weird bug
Screen.Recording.2025-12-07.at.8.33.50.PM.mov
Author
|
@Siumauricio I’m not sure I understand what the bug is. If you enable the system mode and then change your OS theme, the app should switch accordingly — please check whether that works on your side. We might also consider updating the last icon if it’s not clear enough. |
Contributor
Fixed no-ref
Author
|
@Siumauricio fixed, check please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Add support for a system theme option in the theme toggle component, allowing users to switch between light, dark, and system themes.
Checklist
Before submitting this PR, please make sure that:
canarybranch.