Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new Unleash template to enable deployment of the open-source feature management platform via Dokploy. Unleash is properly licensed under Apache 2.0 and the template follows most project conventions.
Changes:
- Adds Unleash blueprint with docker-compose.yml defining the Unleash server and PostgreSQL database services
- Creates template.toml configuration with domain and database variable mappings
- Adds meta.json entry with appropriate metadata and categorization tags
- Includes unleash.png logo file
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| meta.json | Adds Unleash entry with metadata, links, and feature-flag related tags |
| blueprints/unleash/docker-compose.yml | Defines Unleash server and PostgreSQL database services with health checks |
| blueprints/unleash/template.toml | Configures domain mapping and database environment variables |
| blueprints/unleash/unleash.png | Logo file for the Unleash template |
| POSTGRES_DB: "${DB_NAME}" | ||
| POSTGRES_USER: "${DB_USER}" | ||
| POSTGRES_PASSWORD: "${DB_PASSWORD}" |
There was a problem hiding this comment.
The environment variable naming deviates from the established convention in this repository. Most templates (e.g., reactive-resume, docmost, linkwarden, nocodb) use POSTGRES_DB, POSTGRES_USER, and POSTGRES_PASSWORD directly in both docker-compose.yml and template.toml. This template uses intermediate DB_NAME, DB_USER, and DB_PASSWORD variables which adds unnecessary indirection. While this may work functionally, it breaks consistency with the rest of the codebase. Consider changing these to use POSTGRES_* variables directly to follow the established pattern.
| "DB_NAME=${db_name}", | ||
| "DB_USER=${db_user}", | ||
| "DB_PASSWORD=${db_password}" |
There was a problem hiding this comment.
The environment variable naming should match the docker-compose.yml convention used throughout the repository. Most templates use POSTGRES_PASSWORD, POSTGRES_USER, and POSTGRES_DB directly (see blueprints/reactive-resume/template.toml:14, blueprints/nocodb/template.toml:14-16, blueprints/linkwarden/template.toml:15). Change these to POSTGRES_PASSWORD, POSTGRES_USER, and POSTGRES_DB to maintain consistency with the codebase.
1 participant
What is this PR about?
Add Unleash template
Checklist
Before submitting this PR, please make sure that:
Issues related (if applicable)
N/A
Screenshots or Videos
N/A