TDD: Write DBCheckRepository test code

Author: Dokyeongyun

Core/src/main/java/root/core/repository/constracts/DBCheckRepository.java

@@ -1,5 +1,6 @@
 package root.core.repository.constracts;
 
+import java.sql.Connection;
 import java.util.List;
 
 import root.core.domain.ASMDiskUsage;
@@ -9,9 +10,9 @@
 public interface DBCheckRepository {
 	String getDBName();
 
-	Object getTran();
+	Connection getTran();
 
-	void endTran(Object conn);
+	void endTran(Connection conn);
 
 	List<ArchiveUsage> checkArchiveUsage();
 

Repository/.gitignore

@@ -1,3 +1,4 @@
 /build/
 /bin/
-/report
+/report
+/src/test/resources/dbconfig.txt

Repository/src/main/java/root/repository/implement/DBCheckRepositoryImpl.java

@@ -8,12 +8,14 @@
 import java.util.Date;
 import java.util.List;
 
+import lombok.extern.slf4j.Slf4j;
 import root.common.database.contracts.AbstractDatabase;
 import root.core.domain.ASMDiskUsage;
 import root.core.domain.ArchiveUsage;
 import root.core.domain.TableSpaceUsage;
 import root.core.repository.constracts.DBCheckRepository;
 
+@Slf4j
 public class DBCheckRepositoryImpl implements DBCheckRepository {
 	private AbstractDatabase db;
 
@@ -32,9 +34,9 @@ public Connection getTran() {
 	}
 
 	@Override
-	public void endTran(Object conn) {
+	public void endTran(Connection conn) {
 		if (conn != null)
-			db.freeConn((Connection) conn);
+			db.freeConn(conn);
 	}
 
 	@Override
@@ -73,7 +75,7 @@ public List<ArchiveUsage> checkArchiveUsage() {
 			}
 
 		} catch (SQLException e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		} finally {
 			this.endTran(conn);
 		}
@@ -124,7 +126,7 @@ public List<TableSpaceUsage> checkTableSpaceUsage() {
 			}
 
 		} catch (SQLException e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		} finally {
 			this.endTran(conn);
 		}
@@ -185,7 +187,7 @@ public List<ASMDiskUsage> checkASMDiskUsage() {
 			}
 
 		} catch (SQLException e) {
-			e.printStackTrace();
+			log.error(e.getMessage());
 		} finally {
 			this.endTran(conn);
 		}

Repository/src/test/java/root/repository/implement/DBCheckRepositoryTest.java

@@ -0,0 +1,110 @@
+package root.repository.implement;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Paths;
+import java.sql.Connection;
+import java.sql.SQLException;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+
+import root.common.database.implement.JdbcConnectionInfo;
+import root.common.database.implement.JdbcDatabase;
+import root.core.domain.ASMDiskUsage;
+import root.core.domain.ArchiveUsage;
+import root.core.domain.TableSpaceUsage;
+import root.core.repository.constracts.DBCheckRepository;
+
+public class DBCheckRepositoryTest {
+	public static DBCheckRepository repo;
+
+	@BeforeAll
+	public static void setup() {
+
+		// Load db config
+		try {
+			String str = Files.readString(Paths.get("src/test/resources/dbconfig.txt"));
+			String[] split = str.split(",");
+			Map<String, String> configMap = new HashMap<>();
+			for (String s : split) {
+				String[] split2 = s.split("=");
+				configMap.put(split2[0], split2[1]);
+			}
+
+			String jdbcDriver = configMap.get("jdbcDriver");
+			String jdbcUrl = configMap.get("jdbcUrl");
+			String jdbcId = configMap.get("jdbcId");
+			String jdbcPw = configMap.get("jdbcPw");
+			String jdbcValidation = configMap.get("jdbcValidation");
+			int jdbcConnections = Integer.parseInt(configMap.get("jdbcConnections"));
+
+			JdbcConnectionInfo jdbc = new JdbcConnectionInfo(jdbcDriver, jdbcUrl, jdbcId, jdbcPw, jdbcValidation,
+					jdbcConnections);
+			jdbc.setJdbcDBName("testDB");
+			JdbcDatabase db = new JdbcDatabase(jdbc);
+			db.init();
+
+			repo = new DBCheckRepositoryImpl(db);
+
+		} catch (IOException e) {
+			fail(e.getMessage());
+		}
+	}
+
+	@Test
+	public void testGetDBName() {
+		String result = repo.getDBName();
+		assertEquals("testDB", result);
+	}
+
+	@Test
+	public void testGetTran() {
+		Connection result = repo.getTran();
+		assertNotNull(result);
+	}
+
+	@Test
+	public void testEndTran() throws SQLException {
+		Connection conn = repo.getTran();
+		repo.endTran(conn);
+		assertFalse(conn.isClosed());
+
+		repo.endTran(null);
+	}
+
+	@Test
+	public void testCheckArchiveUsage() {
+		// Act
+		List<ArchiveUsage> result = repo.checkArchiveUsage();
+
+		// Assert
+		assertNotNull(result);
+	}
+	
+	@Test
+	public void testCheckTableSpaceUsage() {
+		// Act
+		List<TableSpaceUsage> result = repo.checkTableSpaceUsage();
+
+		// Assert
+		assertNotNull(result);
+	}
+	
+	@Test
+	public void testCheckASMDiskUsage() {
+		// Act
+		List<ASMDiskUsage> result = repo.checkASMDiskUsage();
+
+		// Assert
+		assertNotNull(result);
+	}
+}