-
Notifications
You must be signed in to change notification settings - Fork 322
Add domain authentication configuration for DevOps Stacks #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Linter OK: |
pawel-kow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not yet a review.
Please fill it the PR template properly.
Thank you for your feedback!
Please let me know if anything else needs adjustment. Thank you! |
| "serviceId": "email-authentication", | ||
| "serviceName": "DevOps Stacks Email Authentication", | ||
| "version": 1, | ||
| "logoUrl": "https://devopstacks.com/logo.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. Is the website OK?
$ curl -vso /dev/null https://devopstacks.com/logo.svg
* Trying 192.64.119.191:443...
* connect to 192.64.119.191 port 443 failed: No route to host
* Failed to connect to devopstacks.com port 443 after 10184 ms: No route to host
* Closing connection 0
| "type": "TXT", | ||
| "host": "@", | ||
| "ttl": 3600, | ||
| "data": "%spf_value%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not SPFM?
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->