-
Notifications
You must be signed in to change notification settings - Fork 322
domain connect template for uspeedo.com #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Linter OK: |
|
Could you reconsider use of https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1024 |
@kerolasa I have changed the variable %host% to %subdomain%. Is that okay? |
kerolasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
| { | ||
| "type": "CNAME", | ||
| "groupId": "tracking", | ||
| "host": "%track_host%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this host under %subdomain%?
If it is the whole template could have used @ instead of %subdomain% and standard host parameter, which has quite benefits - template can be applied several times to the same domain and different subdomains if needed.
Otherwise multiInstance setting might be of help.
Description
<-- short description of the template(s) and/or reason for update -->
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverExample variable values
<-- to make review process easier please provide example set of variable values for this template -->
<-- Example: -->
<-- Or provide the whole
testDataobject from the Online Editor after testing and using "Add as test" button -->