-
Notifications
You must be signed in to change notification settings - Fork 322
Add mimeprotect templates #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Linter OK: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds 6 Domain Connect templates for MimeProtect email security services. Each template provides DNS record configuration for a specific email security feature through delegation to MimeProtect's zone management.
Changes:
- Added domain verification template using TXT record for ownership proof
- Added DMARC, SPF, TLS-RPT, MTA-STS, and BIMI templates using CNAME/SPFM delegation
- All templates delegate to
*.zone.mimeprotect.comfor centralized management
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| mimeprotect.com.domain-verification.json | TXT record for domain ownership verification with conflict matching |
| mimeprotect.com.dmarc.json | CNAME delegation for DMARC policy management |
| mimeprotect.com.spf.json | SPFM record for SPF hosting with automatic flattening |
| mimeprotect.com.tlsrpt.json | CNAME for TLS-RPT (SMTP TLS Reporting) |
| mimeprotect.com.mta-sts.json | CNAMEs for MTA-STS policy and well-known endpoint |
| mimeprotect.com.bimi.json | CNAME for BIMI with configurable selector |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
On top of other findings please complete the "Checklist of common problems" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pawel-kow thank you for reviewing. 🙏🏻 I've amended the PR as requested. |
| { | ||
| "type": "CNAME", | ||
| "host": "%bimiSelector%._bimi", | ||
| "pointsTo": "%bimiSelector%._bimi.%domain%.zone.mimeprotect.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question to the use of %domain% variable.
Is it intentional to use it instead of %fqdn%?
The difference is only there visible for subdomains (host parameter not empty). Try with the online editor if the template does what you expect.
Description
Add 6 Domain Connect templates for MimeProtect email security services. Each template handles a specific email security feature, allowing users to apply only what they need:
All records delegate to *.zone.mimeprotect.com for centralized management.
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common prolems of issues (mark all the checkboxes after conducting the check). Comment on any point which is not fulfilled.
syncPubKeyDomainspecified (yes,warnPhishingis an option, but some providers reject such templates by policy, so signing shall be a default)syncRedirectDomainis specified when intended to useredirect_uriparameter in the synchronous flow"v=spf1 ...") instead of using SPFM record type on APEXtxtConflictMatchingModeis set on TXT records which shall be unique on a label (like DMARC)hostparameter%host%variable inhostattributeessentialsetting is used on records, which the user shall be able to change or remove manually later without dropping the whole template (like DMARC)Example variable values