Skip to content

Conversation

@connecthealthmd
Copy link
Contributor

Description

Adding a new template for the ConnectHealthMD white-label service. This allows professionals to connect their subdomains (e.g. www) to our SaaS edge.

Type of change

  • New template
  • Bug fix (non-breaking change which fixes an issue in the template)
  • New feature (non-breaking change which adds functionality to the template)
  • Breaking change (fix or feature that would cause existing template behavior to be not backward compatible)

How Has This Been Tested?

  • Schema validated using JSON Schema template.schema
  • Template functionality checked using Online Editor
  • Template is checked using template linter
  • Template file name follows the pattern <providerId>.<serviceId>.json
  • resource URL provided with logoUrl is actually served by a webserver

Checklist of common problems

  • digital signatures are used and syncPubKeyDomain specified
    • Comment: Public template, syncBlock is false.
  • syncRedirectDomain is specified when intended to use redirect_uri parameter in the synchronous flow
  • no TXT record with SPF content (i.e. "v=spf1 ...") instead of using SPFM record type on APEX
  • txtConflictMatchingMode is set on TXT records which shall be unique on a label (like DMARC)
  • variables are set to the smallest scope needed
  • no variables as a host name to apply template on subdomain instead of standard host parameter
  • no explicit usage of %host% variable in host attribute
  • essential setting is used on records, which the user shall be able to change or remove manually later without dropping the whole template

Example variable values

verifyToken: a1b2c3d4e5f6

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Linter OK:

Linter result for connecthealthmd.com.white-label.json

@kerolasa kerolasa self-requested a review January 30, 2026 10:05
kerolasa
kerolasa previously approved these changes Jan 30, 2026
Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pawel-kow
Copy link
Member

@connecthealthmd you wrote

  • digital signatures are used and syncPubKeyDomain specified
    Comment: Public template, syncBlock is false.

How are these 2 things related? Is your intention, that the apply link would be created by multiple parties so that signing is impossible?

@connecthealthmd
Copy link
Contributor Author

@connecthealthmd you wrote

  • digital signatures are used and syncPubKeyDomain specified
    Comment: Public template, syncBlock is false.

How are these 2 things related? Is your intention, that the apply link would be created by multiple parties so that signing is impossible?

@connecthealthmd you wrote

  • digital signatures are used and syncPubKeyDomain specified
    Comment: Public template, syncBlock is false.

How are these 2 things related? Is your intention, that the apply link would be created by multiple parties so that signing is impossible?

Thanks for pointing that out. I have updated the template to support standard RSA signatures (syncPubKeyDomain and syncPubKey added). Our setup is now live.

@pawel-kow
Copy link
Member

@connecthealthmd I recommend reading the specification and not trusting that your AI tool will do the work properly! They are pretty good at hallucinating properties not existing in the specification.

@pawel-kow pawel-kow added the AI crap AI generated pull request without proper human control or review label Feb 1, 2026
Removed syncPubKey as that is not part of the specification and should not have been included.
@connecthealthmd
Copy link
Contributor Author

@connecthealthmd I recommend reading the specification and not trusting that your AI tool will do the work properly! They are pretty good at hallucinating properties not existing in the specification.

I should've trusted my instinct instead of having it reviewed before I submitted and convincing me otherwise.

@connecthealthmd I recommend reading the specification and not trusting that your AI tool will do the work properly! They are pretty good at hallucinating properties not existing in the specification.

Yup, my apologies for putting in the wrong property. I re-read the spec and syncPubKey does NOT exist. I removed it from the JSON and left the syncPubKeyDomain exactly as the spec described. If anything else is needed I will make the changes myself without considering other opinions.

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@pawel-kow pawel-kow enabled auto-merge February 2, 2026 06:24
@pawel-kow pawel-kow added this pull request to the merge queue Feb 2, 2026
Merged via the queue into Domain-Connect:master with commit 35210f4 Feb 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI crap AI generated pull request without proper human control or review question

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants