-
Notifications
You must be signed in to change notification settings - Fork 335
Add ConnectHealthMD White Label Template #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linter OK: |
kerolasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@connecthealthmd you wrote
How are these 2 things related? Is your intention, that the apply link would be created by multiple parties so that signing is impossible? |
Thanks for pointing that out. I have updated the template to support standard RSA signatures (syncPubKeyDomain and syncPubKey added). Our setup is now live. |
|
@connecthealthmd I recommend reading the specification and not trusting that your AI tool will do the work properly! They are pretty good at hallucinating properties not existing in the specification. |
Removed syncPubKey as that is not part of the specification and should not have been included.
I should've trusted my instinct instead of having it reviewed before I submitted and convincing me otherwise.
Yup, my apologies for putting in the wrong property. I re-read the spec and syncPubKey does NOT exist. I removed it from the JSON and left the syncPubKeyDomain exactly as the spec described. If anything else is needed I will make the changes myself without considering other opinions. |
pawel-kow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx
Description
Adding a new template for the ConnectHealthMD white-label service. This allows professionals to connect their subdomains (e.g. www) to our SaaS edge.
Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
syncPubKeyDomainspecifiedsyncRedirectDomainis specified when intended to useredirect_uriparameter in the synchronous flow"v=spf1 ...") instead of using SPFM record type on APEXtxtConflictMatchingModeis set on TXT records which shall be unique on a label (like DMARC)hostparameter%host%variable inhostattributeessentialsetting is used on records, which the user shall be able to change or remove manually later without dropping the whole templateExample variable values
verifyToken: a1b2c3d4e5f6