-
Notifications
You must be signed in to change notification settings - Fork 33
IDEV-2020 handle large response feeds improved #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3c2d37b
Revert "IDEV-2020: Handle partial response from RTUF endpoints."
jbabac 0c7b051
IDEV-2020: Create FeedsResults class for results generator for feeds …
jbabac 18ffd9c
IDEV-2020: Use the FeedsResults class.
jbabac f3a15c6
IDEV-2020: Adjust cli implementation
jbabac 23f3fbf
IDEV-2020: Adjust tests.
jbabac 9bb7e8c
IDEV-2020: Use typing.Generator.
jbabac 3953216
IDEV-2020: Fix type hint to FeedsResults. It should be the .response(…
jbabac 6a8a76a
IDEV-2020: Refactor checking limit exceeded and remove feeds product …
jbabac ee1577b
IDEV-2020: Override self.data() method to isolate handling of FeedsRe…
jbabac 711418d
IDEV-2020: Raise the exception at the end.
jbabac 0bca37b
IDEV-2020: Make "Limit Exceeded" the default reason.
jbabac File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a pedantic change:
can we put the
Limit Exceededas default reason? so we dont need to define it in elif and just concat the message in theifstatement.Overall, LGTM ✅ . Nice!!