Remove some unused telemetry events from index.ts (#18805)

* remove platform.info

* Delete join mailing list events from index.ts

* Change python3 property to pythonThree

* Delete unused declarations

* Remove one more unused declaration

Author: luabud

src/client/common/platform/platformService.ts

@@ -6,8 +6,6 @@
 import { injectable } from 'inversify';
 import * as os from 'os';
 import { coerce, SemVer } from 'semver';
-import { sendTelemetryEvent } from '../../telemetry';
-import { EventName, PlatformErrors } from '../../telemetry/constants';
 import { getSearchPathEnvVarNames } from '../utils/exec';
 import { Architecture, getArchitecture, getOSType, OSType } from '../utils/platform';
 import { parseSemVerSafe } from '../utils/version';
@@ -19,14 +17,6 @@ export class PlatformService implements IPlatformService {
 
     public version?: SemVer;
 
-    constructor() {
-        if (this.osType === OSType.Unknown) {
-            sendTelemetryEvent(EventName.PLATFORM_INFO, undefined, {
-                failureType: PlatformErrors.FailedToDetermineOS,
-            });
-        }
-    }
-
     public get pathVariableName(): 'Path' | 'PATH' {
         return getSearchPathEnvVarNames(this.osType)[0];
     }
@@ -48,17 +38,11 @@ export class PlatformService implements IPlatformService {
                 try {
                     const ver = coerce(os.release());
                     if (ver) {
-                        sendTelemetryEvent(EventName.PLATFORM_INFO, undefined, {
-                            osVersion: `${ver.major}.${ver.minor}.${ver.patch}`,
-                        });
                         this.version = ver;
                         return this.version;
                     }
                     throw new Error('Unable to parse version');
                 } catch (ex) {
-                    sendTelemetryEvent(EventName.PLATFORM_INFO, undefined, {
-                        failureType: PlatformErrors.FailedToParseVersion,
-                    });
                     return parseSemVerSafe(os.release());
                 }
             default:

src/client/startupTelemetry.ts

@@ -93,7 +93,7 @@ async function getActivationTelemetryProps(serviceContainer: IServiceContainer):
     const mainWorkspaceUri = workspaceService.hasWorkspaceFolders
         ? workspaceService.workspaceFolders![0].uri
         : undefined;
-    const [condaVersion, hasPython3] = await Promise.all([
+    const [condaVersion, hasPythonThree] = await Promise.all([
         condaLocator
             .getCondaVersion()
             .then((ver) => (ver ? ver.raw : ''))
@@ -125,7 +125,7 @@ async function getActivationTelemetryProps(serviceContainer: IServiceContainer):
         pythonVersion,
         interpreterType,
         workspaceFolderCount,
-        hasPython3,
+        hasPythonThree,
         usingUserDefinedInterpreter,
         usingGlobalInterpreter,
     };

src/client/telemetry/constants.ts

@@ -64,8 +64,6 @@ export enum EventName {
     PYTHON_EXPERIMENTS_OPT_IN_OPT_OUT_SETTINGS = 'PYTHON_EXPERIMENTS_OPT_IN_OPT_OUT_SETTINGS',
 
     EXTENSION_SURVEY_PROMPT = 'EXTENSION_SURVEY_PROMPT',
-    JOIN_MAILING_LIST_PROMPT_DISPLAYED = 'JOIN_MAILING_LIST_PROMPT_DISPLAYED',
-    JOIN_MAILING_LIST_PROMPT = 'JOIN_MAILING_LIST_PROMPT',
 
     PYTHON_LANGUAGE_SERVER_STARTUP_DURATION = 'PYTHON_LANGUAGE_SERVER_STARTUP_DURATION',
     PYTHON_LANGUAGE_SERVER_CURRENT_SELECTION = 'PYTHON_LANGUAGE_SERVER_CURRENT_SELECTION',
@@ -81,7 +79,6 @@ export enum EventName {
     ACTIVATE_ENV_TO_GET_ENV_VARS_FAILED = 'ACTIVATE_ENV_TO_GET_ENV_VARS_FAILED',
     DIAGNOSTICS_ACTION = 'DIAGNOSTICS.ACTION',
     DIAGNOSTICS_MESSAGE = 'DIAGNOSTICS.MESSAGE',
-    PLATFORM_INFO = 'PLATFORM.INFO',
 
     SELECT_LINTER = 'LINTING.SELECT',
     USE_REPORT_ISSUE_COMMAND = 'USE_REPORT_ISSUE_COMMAND',

src/client/telemetry/index.ts

@@ -21,7 +21,7 @@ import {
     TensorBoardSessionStartResult,
     TensorBoardEntrypoint,
 } from '../tensorBoard/constants';
-import { EventName, PlatformErrors } from './constants';
+import { EventName } from './constants';
 import type { LinterTrigger, TestTool } from './types';
 
 /**
@@ -742,7 +742,7 @@ export interface IEventNamePropertyMapping {
           "interpretertype" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
           "terminal" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "owner": "luabud" },
           "workspacefoldercount" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
-          "haspython3" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
+          "haspythonthree" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
           "startactivatetime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
           "totalactivatetime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
           "totalnonblockingactivatetime" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" },
@@ -776,7 +776,7 @@ export interface IEventNamePropertyMapping {
         /**
          * If interpreters found for the main workspace contains a python3 interpreter
          */
-        hasPython3?: boolean;
+        hasPythonThree?: boolean;
         /**
          * If user has defined an interpreter in settings.json
          */
@@ -1029,29 +1029,6 @@ export interface IEventNamePropertyMapping {
          */
         executableSpecified: boolean;
     };
-    /**
-     * Telemetry event sent after fetching the OS version
-     */
-    /* __GDPR__
-       "platform.info" : {
-          "failuretype" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "owner": "luabud" },
-          "osversion" : { "classification": "SystemMetaData", "purpose": "PerformanceAndHealth", "owner": "luabud" }
-       }
-     */
-    [EventName.PLATFORM_INFO]: {
-        /**
-         * If fetching OS version fails, list the failure type
-         *
-         * @type {PlatformErrors}
-         */
-        failureType?: PlatformErrors;
-        /**
-         * The OS version of the platform
-         *
-         * @type {string}
-         */
-        osVersion?: string;
-    };
     /**
      * Telemetry event sent when an environment without contain a python binary is selected.
      */
@@ -1595,27 +1572,6 @@ export interface IEventNamePropertyMapping {
          */
         selection: 'Yes' | 'Maybe later' | 'Do not show again' | undefined;
     };
-    /**
-     * Telemetry sent back when join mailing list prompt is shown.
-     */
-    /* __GDPR__
-       "join_mailing_list_prompt_displayed" : { }
-     */
-    [EventName.JOIN_MAILING_LIST_PROMPT_DISPLAYED]: never | undefined;
-    /**
-     * Telemetry sent back when user selects an option from join mailing list prompt.
-     */
-    /* __GDPR__
-       "join_mailing_list_prompt" : {
-          "selection" : { "classification": "SystemMetaData", "purpose": "FeatureInsight", "owner": "luabud" }
-       }
-     */
-    [EventName.JOIN_MAILING_LIST_PROMPT]: {
-        /**
-         * Carries the selection of user when they are asked to join the mailing list.
-         */
-        selection: 'Yes' | 'No' | undefined;
-    };
     /**
      * Telemetry event sent when starting REPL
      */