Bump actions/upload-artifact from 2 to 3

.devcontainer/Dockerfile

@@ -0,0 +1,23 @@
+FROM node:16-slim
+# WORKDIR /app
+# COPY . /app
+# RUN npm install
+# EXPOSE 3000
+# CMD ["node", "index.js"]
+
+# # See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.227.0/containers/javascript-node/.devcontainer/base.Dockerfile
+
+# # [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 16, 14, 12, 16-bullseye, 14-bullseye, 12-bullseye, 16-buster, 14-buster, 12-buster
+# ARG VARIANT="16-bullseye"
+# FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
+
+# # [Optional] Uncomment this section to install additional OS packages.
+# # RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
+# #     && apt-get -y install --no-install-recommends <your-package-list-here>
+
+# # [Optional] Uncomment if you want to install an additional version of node using nvm
+# # ARG EXTRA_NODE_VERSION=10
+# # RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
+
+# # [Optional] Uncomment if you want to install more global node modules
+# # RUN su node -c "npm install -g <your-package-list-here>"

.devcontainer/devcontainer.json

@@ -0,0 +1,29 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
+// https://github.com/microsoft/vscode-dev-containers/tree/v0.227.0/containers/javascript-node
+{
+	"name": "Node.js",
+	"build": {
+		"dockerfile": "Dockerfile",
+		// Update 'VARIANT' to pick a Node version: 16, 14, 12.
+		// Append -bullseye or -buster to pin to an OS version.
+		// Use -bullseye variants on local arm64/Apple Silicon.
+		// "args": { "VARIANT": "16" }
+	},
+
+	// Set *default* container specific settings.json values on container create.
+	"settings": {},
+
+	// Add the IDs of extensions you want installed when the container is created.
+	"extensions": [
+		"dbaeumer.vscode-eslint"
+	],
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	// "postCreateCommand": "yarn install",
+
+	// Comment out to connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
+	"remoteUser": "node"
+}

.eslintrc

@@ -22,7 +22,8 @@
                 "ts-ignore": "allow-with-description"
             }
         ],
-        "@typescript-eslint/explicit-module-boundary-types": "error",
+        "consistent-return": "off",
+        "@typescript-eslint/explicit-module-boundary-types": "off",
         "no-bitwise": "off",
         "no-dupe-class-members": "off",
         "@typescript-eslint/no-dupe-class-members": "error",
@@ -51,7 +52,7 @@
         "@typescript-eslint/no-var-requires": "off",
 
         // Other rules
-        "class-methods-use-this": ["error", {"exceptMethods": ["dispose"]}],
+        "class-methods-use-this": ["error", { "exceptMethods": ["dispose"] }],
         "func-names": "off",
         "import/extensions": "off",
         "import/namespace": "off",

.github/workflows/pr-check.yml

@@ -502,7 +502,7 @@ jobs:
         run: npm run test:cover:report
 
       - name: Upload HTML report
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v3
         with:
           name: ${{ runner.os }}-coverage-report-html
           path: ./coverage

.vscode/settings.json

@@ -8,7 +8,7 @@
         "obj": true,
         "bin": true,
         "**/__pycache__": true,
-        "**/node_modules": true,
+        "**/node_modules": false,
         ".vscode-test": false,
         ".vscode test": false,
         "**/.mypy_cache/**": true
@@ -26,7 +26,7 @@
         "editor.formatOnSave": true
     },
     "[typescript]": {
-        "editor.defaultFormatter": "rvest.vs-code-prettier-eslint",
+        "editor.defaultFormatter": "vscode.typescript-language-features",
         "editor.formatOnSave": true
     },
     "[javascript]": {