[Refactor/#7] Optimize recomposition using graphicsLayer#8
Merged
DongChyeon merged 2 commits intomainfrom Nov 9, 2025
Merged
Conversation
…ng graphicsLayer lambda
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the curved picker effect implementation by extracting inline calculations into a dedicated modifier extension function. The change improves code organization and maintainability by separating the visual effect logic from the main composable content.
- Extracted visual effect calculations (alpha and scaleY) into a new
curvedPickerEffectmodifier extension function - Removed
derivedStateOfusage and directgraphicsLayerapplication in favor of the new modifier - Simplified the Text composable by removing inline alpha calculations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timepicker/src/main/java/com/dongchyeon/timepicker/ui/PickerItem.kt
Outdated
Show resolved
Hide resolved
timepicker/src/main/java/com/dongchyeon/timepicker/ui/PickerItem.kt
Outdated
Show resolved
Hide resolved
…icsLayer and rememberUpdatedState
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Related Issue
📝 Description
What does this PR do?
Extracts the curve effect calculation logic from the LazyColumn item into a reusable Modifier.curvedPickerEffect() extension.
This refactor moves visual transformation logic (alpha, scaleY) into a graphicsLayer lambda,
reducing unnecessary recompositions during scroll and improving frame stability.
✅ Changes
🔍 Screenshots / Test Results (if applicable)
👤 Reviewer Checklist