Skip to content

Conversation

@vikingnope
Copy link
Contributor

@vikingnope vikingnope commented Nov 2, 2025

NOT READY FOR REVIEW

This Pull Request should stay as draft. Still a WORK IN PROGRESS

Pull Request Description

This pull request adds support for automated Flathub packaging and submission for the Fladder project. The main changes include the introduction of a GitHub Actions workflow to update and submit Flathub manifests on release builds, and the addition of the necessary Flathub manifest and metadata files for Fladder.

Flathub packaging and workflow automation:

  • Added a new flathub-package-submit job to .github/workflows/build.yml that automatically updates Flathub manifests and creates a pull request to the Flathub repository on each release build. This includes steps for manifest updates, versioning, and metadata handling.

Flathub manifest and metadata files:

  • Added a new Flathub manifest file flatpak/nl.jknaapen.fladder.flathub.yaml describing how to build and package Fladder and its dependencies (mpv, zenity, Flutter SDK, etc.) for Flathub.
  • Added a new Flathub metainfo file flatpak/nl.jknaapen.fladder.metainfo.xml providing metadata, description, screenshots, and release information for Fladder on Flathub.

Issue Being Fixed

Resolves #390

Screenshots / Recordings

What still needs to be done:

  • Verify Flatpak package fully works
  • Create Pull Request for first upload of Fladder to Flathub
  • Change code to point to correct repo

Checklist

  • If a new package was added, did you ensure it works for all supported platforms? Is the package well maintained
  • Check that any changes are related to the issue at hand.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 2, 2025

Reviewer's Guide

Automates Flathub packaging and submission by adding a dedicated GitHub Actions job and including the necessary Flatpak manifest and metadata for Fladder.

Entity relationship diagram for new Flathub manifest and metainfo files

erDiagram
  FLATPAK_MANIFEST {
    string id
    string runtime
    string runtime-version
    string sdk
    string command
    list modules
  }
  METAINFO_XML {
    string id
    string name
    string summary
    string description
    list screenshots
    list releases
    list categories
    list keywords
  }
  FLATPAK_MANIFEST ||--|| METAINFO_XML : "references"
  FLATPAK_MANIFEST ||--|{ MODULE : "contains"
  MODULE {
    string name
    string buildsystem
    list sources
  }
Loading

File-Level Changes

Change Details Files
Introduce GitHub Actions job for Flathub submission
  • Add flathub-package-submit job to CI
  • Checkout main and Flathub repos
  • Copy and update manifest and metainfo files
  • Update manifest tag, commit hash, and metainfo version/date
  • Create PR to Flathub repository
.github/workflows/build.yml
Add Flathub Flatpak manifest
  • Define runtime, SDK, and finish args
  • Include modules for mpv, zenity, Flutter SDK, and Fladder
  • Configure build and cleanup steps for each module
flatpak/nl.jknaapen.fladder.flathub.yaml
Add Flathub application metadata
  • Provide app description, features list, and screenshots
  • Define release element for versioning
  • Specify categories, keywords, and developer info
flatpak/nl.jknaapen.fladder.metainfo.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New security issues found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant