feat: Add tizen support #680
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
further testing will be needed
controls and colors are still not great. more work needs done
created a specific video_player_controls for the tizen. Can possibly be used for all TVs. It is mostly just a copy of the already existing DesktopOverlay.
there was an issue where there was added an extra / in the transcode url. not sure why. I've removed it in a imo not so great way, but is, for now, fixes the issue
small other fixes and clean up of code
reused the videoWidget from lib_mkd, which is correctly setup and thereby fixed the issue. corrected other small things
Added tizen_video_hole to be able to scale the video player independant of the UI scaling of the app. Also removed TrueHD from tizen_profile because only some TrueHD seem to be working
also updated version number
popdollar
force-pushed
the
feat/add-tizen-support
branch
from
3dcc76d to
d8e7737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Added support Tizen OS 6.0+ for Samsung TVs. It is in a working state (at least on my TV S90C and the emulator).
It is build with Samsungs Flutter SDK.
I've used tizens videohole video_player since they recommend using it when specifically targeting TVs.
Disclaimer
I've targeted main functionality and there might be changes that are breaking, since this have not been tested with any other OS. I don't believe the additional packages specifically for Tizen are breaking for any other clients, but I can not guarantee anything.
Checklist