fix: Seerr requests check incorrect permission to determine whether the user can request as someone else#737
Merged
PartyDonut merged 2 commits intoDonutWare:developfrom Feb 7, 2026
Conversation
PartyDonut
approved these changes
Feb 7, 2026
Collaborator
PartyDonut
left a comment
PartyDonut
left a comment
There was a problem hiding this comment.
Nice find, thanks for implementing/fixing it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently in the seerr integration we have a dropdown to select whether to request as a different user, and to check if we submit this different ID we check the "Manage Requests" permission, even though it is determined by the "Manage Users" permission (this would lead to a 403 if the current user doesnt have the permission, even if the selected user is the same as the current user).
This PR fixes this, and also hides this dropdown if the user doesn't have the required permission to use this feature.
Issue Being Fixed
Resolves #719 (at least I think? this is definitely part of the issue at least)
Screenshots / Recordings
Checklist