Closed
Conversation
|
I kind of like the play button in the middle. If the video is paused windowed and there's no mouse focus on the player it's a good indicator the player is in a pause state. Also more UI friendly to older folks when teaching them how to use app. |
Contributor
Author
|
@talynone, I was trying to make it more like the mobile apps since those only show the single Play/Pause button at the bottom whether the screen is touched or not during playback. I also don't like the icon in the middle 😆 I can add it behind an option, but I'll wait until PartyDonut has a chance to review it. |
Collaborator
|
Like @talynone mentioned, I like having a pause button in the middle as a indicator that it's actually paused. So closing this for now. Feel free to open a discussion however for any UI/UX ideas. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Removes the big desktop-only play button in the middle of the screen that persists regardless of mouse panning.
There's already a play/pause button at the bottom control bar, so now it has tooltips depending on the playback state (Pause video and Resume video).
Issue Being Fixed
I haven't created an issue for it yet, but will if needed.
Screenshots / Recordings
Checklist