Skip to content

update#29

Merged
joshunrau merged 15 commits intomainfrom
dev
Mar 30, 2025
Merged

update#29
joshunrau merged 15 commits intomainfrom
dev

Conversation

@joshunrau
Copy link
Collaborator

@joshunrau joshunrau commented Mar 30, 2025

  • add setAccessToken method to e2e test api
  • add support for global prisma omit
  • small refactor of prisma module to allow granular override of connection string

Summary by CodeRabbit

  • New Features

    • Enhanced database integration by supporting custom Prisma configurations and streamlined MongoDB connection setup.
    • Added improved token management for authentication testing.
  • Refactor

    • Updated initialization and naming conventions for clearer configuration handling and increased type safety.
    • Simplified test setup by removing unnecessary mock configurations.
  • Tests

    • Expanded test coverage to verify custom database parameters and connection URL formatting.

@joshunrau joshunrau merged commit 529faef into main Mar 30, 2025
1 check failed
@coderabbitai
Copy link

coderabbitai bot commented Mar 30, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes refactor several parts of the application to integrate a new Prisma global omit configuration and switch from using Prisma-based dependency injection to MongoDB-based injections. The updates include renaming methods, extending type signatures with new type parameters, and modifying test files. Additionally, changes in the Prisma module cover new tokens, simplified client creation, and updated configuration providers. These modifications are spread across application container, factory, module, test, and configuration files to ensure consistency and greater flexibility in handling Prisma and MongoDB configurations.

Changes

File(s) Change Summary
src/app/__tests__/app.factory.test.ts, src/app/app.factory.ts, src/app/app.container.ts Renamed createApp to createAppContainer; added a test case for custom Prisma configuration; updated class and factory signatures with a new Prisma global omit type parameter.
src/modules/prisma/... (includes prisma.config.ts, prisma.factory.ts, prisma.module.ts, prisma.types.ts, and tests) Introduced DefaultPrismaGlobalOmitConfig and updated PrismaModuleOptions generics; added MONGO_CONNECTION_TOKEN; refactored dependency injection and connection URL construction; updated tests to reflect new runtime options and eliminated legacy mocks.
src/testing/helpers/e2e.ts Replaced usage of PRISMA_CLIENT_TOKEN with MONGO_CONNECTION_TOKEN; updated TestAgent to include setAccessToken and removed the auth method.
src/user-config.ts Modified InferUserConfig type signature to include both PrismaGlobalOmitConfig and RuntimeEnv in the returned AppContainer type.

Sequence Diagram(s)

sequenceDiagram
    participant AppFactory
    participant PrismaModule
    participant ConfigService
    participant PrismaFactory
    participant PrismaClient

    AppFactory->>PrismaModule: forRoot({ dbPrefix, omit })
    PrismaModule->>ConfigService: Retrieve MongoDB configuration
    ConfigService-->>PrismaModule: Return config values
    PrismaModule->>PrismaFactory: Provide MONGO_CONNECTION_TOKEN (mongoConnection URL)
    PrismaFactory->>PrismaClient: Create client using datasourceUrl & optional omit
Loading

Suggested labels

released

Poem

I'm a hopping rabbit, trotting through fresh code,
New tokens and types lighten my joyful load.
From Prisma twists to Mongo's clear, bright stream,
Every line now sparkles like a daydream.
With each committed change, my smile grows wide—
A carrot-filled cheer for a rabbit's coding stride!
🥕🐇


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17e8fb5 and 87a6c79.

📒 Files selected for processing (11)
  • src/app/__tests__/app.factory.test.ts (7 hunks)
  • src/app/app.container.ts (2 hunks)
  • src/app/app.factory.ts (1 hunks)
  • src/modules/prisma/__tests__/prisma.factory.test.ts (3 hunks)
  • src/modules/prisma/__tests__/prisma.module.test.ts (1 hunks)
  • src/modules/prisma/prisma.config.ts (1 hunks)
  • src/modules/prisma/prisma.factory.ts (2 hunks)
  • src/modules/prisma/prisma.module.ts (2 hunks)
  • src/modules/prisma/prisma.types.ts (2 hunks)
  • src/testing/helpers/e2e.ts (4 hunks)
  • src/user-config.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coderabbitai coderabbitai bot mentioned this pull request Apr 24, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant