Implement new DataTable #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: DataTable has been completely rewritten
|
Caution Review failedThe pull request is closed. WalkthroughThe DataTable component undergoes architectural refactoring from an inline React Table implementation to a store-based, context-driven design. Zustand store management centralizes table state; modular sub-components handle head, body, controls, pagination, and empty states. Test infrastructure updates remove global zustand mocking. DestructiveActionDialog and RowActionsDropdown components are removed. Changes
Sequence DiagramsequenceDiagram
participant App as Application
participant DT as DataTable
participant Store as DataTableStore<br/>(Zustand)
participant Ctx as DataTableContext
participant Controls as DataTableControls
participant Head as DataTableHead
participant Body as DataTableBody
participant Hooks as Custom Hooks
App->>DT: Render with props
DT->>Store: createDataTableStore(params)
DT->>Ctx: Provide store context
Ctx->>Controls: Render (with context)
Ctx->>Head: Render (with context)
Ctx->>Body: Render (with context)
Controls->>Hooks: useDataTableStore()
Hooks->>Store: Read globalFilter, setGlobalFilter
Controls->>Controls: Render SearchBar + Toggles
Head->>Hooks: useDataTableHandle('headerGroups')
Hooks->>Store: Access memoized headerGroups
Head->>Head: Render headers with sticky pins
Body->>Hooks: useDataTableHandle('rows')
Hooks->>Store: Access memoized rows
Body->>Body: Render rows with cells
Controls->>Store: Update global filter on search
Store->>Store: Invalidate memoized handles
Hooks-->>Head: Re-derive headerGroups
Hooks-->>Body: Re-derive rows
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (23)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Refactor
Tests
Chores
✏️ Tip: You can customize this high-level summary in your review settings.