Futures #1384
Merged
Futures #1384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeDSM
force-pushed
the
futures
branch
2 times, most recently
from
4afc8ec to
3951803
Compare
GuillaumeDSM
force-pushed
the
futures
branch
from
3951803 to
61107d9
Compare
Herklos
reviewed
Nov 30, 2024
Comment on lines
-279
to
-290
| parsed[trading_enums.ExchangeConstantsPositionColumns.MARGIN_TYPE.value] = \ | ||
| trading_enums.MarginType( | ||
| fixed.get(ccxt_enums.ExchangePositionCCXTColumns.MARGIN_MODE.value) | ||
| ) | ||
| # use one way by default. | ||
| if parsed[trading_enums.ExchangeConstantsPositionColumns.POSITION_MODE.value] is None: | ||
| parsed[trading_enums.ExchangeConstantsPositionColumns.POSITION_MODE.value] = ( | ||
| trading_enums.PositionMode.HEDGE if fixed.get(ccxt_enums.ExchangePositionCCXTColumns.HEDGED.value, | ||
| True) | ||
| else trading_enums.PositionMode.ONE_WAY | ||
| ) | ||
| return parsed |
Member
There was a problem hiding this comment.
It's not necessary anymore right?
Member
Author
There was a problem hiding this comment.
| # "marginMode": "ISOLATED" // Added field for margin mode: ISOLATED, CROSS, default: ISOLATED | ||
| # from https://www.kucoin.com/docs/rest/futures-trading/orders/place-order | ||
| if ( | ||
| KucoinCCXTAdapter.KUCOIN_MARGIN_MODE not in params and |
Herklos
approved these changes
Dec 1, 2024
Herklos
approved these changes
Dec 1, 2024
Herklos
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.