Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
Trading/Mode/daily_trading_mode/daily_trading.py:435
- The error message could be improved for clarity and grammar. Consider rephrasing to clarify that missing price info prevents enforcing the maximum currency percentage and suggest corrective action more directly.
self.logger.error(f"Missing price information in reference market for {currency}. Skipping buy order as is it required to ensure the maximum currency percent parameter. Set it to 100 to buy anyway.")
Trading/Mode/daily_trading_mode/daily_trading.py:317
- [nitpick] The parameter name 'base' may be ambiguous given the previous use of 'quote' in similar contexts. Consider renaming or adding comments to clarify its purpose in relation to the reference market.
async def _get_limit_quantity_from_risk(self, ctx, eval_note, max_quantity, base, selling, increasing_position):
Herklos
approved these changes
Apr 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now always consider the max coin ratio param