Skip to content

[DailyTrading] fix max ratio#1475

Merged
GuillaumeDSM merged 1 commit intodevfrom
daily
Apr 6, 2025
Merged

[DailyTrading] fix max ratio#1475
GuillaumeDSM merged 1 commit intodevfrom
daily

Conversation

@GuillaumeDSM
Copy link
Member

@GuillaumeDSM GuillaumeDSM commented Apr 6, 2025

now always consider the max coin ratio param

@GuillaumeDSM GuillaumeDSM requested review from Herklos and Copilot April 6, 2025 11:59
@GuillaumeDSM GuillaumeDSM self-assigned this Apr 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

Trading/Mode/daily_trading_mode/daily_trading.py:435

  • The error message could be improved for clarity and grammar. Consider rephrasing to clarify that missing price info prevents enforcing the maximum currency percentage and suggest corrective action more directly.
self.logger.error(f"Missing price information in reference market for {currency}. Skipping buy order as is it required to ensure the maximum currency percent parameter. Set it to 100 to buy anyway.")

Trading/Mode/daily_trading_mode/daily_trading.py:317

  • [nitpick] The parameter name 'base' may be ambiguous given the previous use of 'quote' in similar contexts. Consider renaming or adding comments to clarify its purpose in relation to the reference market.
async def _get_limit_quantity_from_risk(self, ctx, eval_note, max_quantity, base, selling, increasing_position):

@GuillaumeDSM GuillaumeDSM merged commit 4620743 into dev Apr 6, 2025
5 checks passed
@GuillaumeDSM GuillaumeDSM deleted the daily branch April 6, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants