Skip to content

[HollaEx] handle missing fees #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuillaumeDSM merged 1 commit into from
Dec 17, 2025
Merged

[HollaEx] handle missing fees #1666

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Trading/Exchange/hollaex/hollaex_exchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,10 @@ def get_fees(self, symbol):
fee_tiers = self._get_fee_tiers(self.exchange_manager.exchange, is_real_trading)
return self._get_fees(self.exchange_manager.exchange_name, fee_tiers, symbol)
except errors.MissingFeeDetailsError:
self.logger.error(f"Missing fee details, using default value")
if _EXCHANGE_FEE_TIERS_BY_EXCHANGE_NAME.get(self.exchange_manager.exchange_name):
self.logger.error(f"Missing {self.exchange_manager.exchange_name} {symbol} fee details, using default value")
else:
self.logger.warning(f"Missing all {self.exchange_manager.exchange_name} fee details, using ccxt default values")
market = self.get_market_status(symbol, with_fixer=False)
# use default ccxt values
return {
Expand Down Expand Up @@ -309,6 +312,11 @@ def _get_fetched_fees(cls, exchange: str, tier_to_use: FeeTiers, symbol: str):
try:
return exchange_fees[tier_to_use.value][symbol]
except KeyError as err:
if not exchange_fees:
# mssing exchange fees, should not happen
raise errors.MissingFeeDetailsError(
f"Unexpected: missing {exchange} fee details"
) from err
if symbol not in exchange_fees[FeeTiers.BASIC.value]:
default_fee_symbol = cls._get_default_fee_symbol(exchange)
if symbol == default_fee_symbol:
Expand Down