[TradingMode] fix convertor with simulated liimit order #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
reviewed
Nov 17, 2024
octobot_trading/modes/modes_util.py
Outdated
| initialized_order = await trading_mode.create_order(order) | ||
| if ( | ||
| isinstance(initialized_order, trading_personal_data.LimitOrder) | ||
| and initialized_order.trader.exchange_manager.trader.simulate |
Member
There was a problem hiding this comment.
Suggested change
| and initialized_order.trader.exchange_manager.trader.simulate | |
| and initialized_order.is_simulated() |
I don't remember if this method exists
Member
Author
There was a problem hiding this comment.
right, there is a simulated attribute, I update this
Herklos
reviewed
Nov 17, 2024
octobot_trading/modes/modes_util.py
Outdated
| initialized_order = await trading_mode.create_order(order) | ||
| if isinstance(initialized_order, trading_personal_data.LimitOrder) and initialized_order.simulated: | ||
| # on simulator, this order should be instantly filled now as its price is meant to be instantly filled | ||
| await initialized_order.on_fill() |
Member
There was a problem hiding this comment.
Shouldn't we create a wrapper like create_market_order that creates a market order or a limit order (depending on what's available for this exchange) and that triggers order.on_fill() for the limit order.
It seems to be an issue that could happen again in another function who would do the same thing
Member
Author
There was a problem hiding this comment.
right, it's now in convert_with_market_or_limit_order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.