add full requirements #1300
add full requirements #1300
Conversation
| """ | ||
| try: | ||
| await client.load_markets(reload=reload) | ||
| if constants.FETCH_MIN_EXCHANGE_MARKETS and market_filter: |
There was a problem hiding this comment.
Why a constant and not a connector class attribute?
There was a problem hiding this comment.
we don't always want to do this. this filter is very strict (it prevents CCXT from even considering certain markets, unlike regular market filters which allow ccxt to load all markets and then filters out unrequired ones in next created exchanges). It should only be used in specific contexts, it's not a "per exchange" thing.
That's why it's a constant bound to an env var: it can be enabled but only if the user explicitely asks for it (it uses ccxt common interface so it should work for all ccxt exchanges)
There was a problem hiding this comment.
I still don't understand why an environment variable vs a parameter that could be based on a env var value. I don't get why we should use an env var here. That's my point. If this value is based on an environment var somewhere else why not. I don't understand why we want to "lock" this value with an environment variable instead of a class param that could use the value of an environment variable
requires Drakkar-Software/OctoBot-Tentacles-Manager#186
requires Drakkar-Software/OctoBot-Backtesting#189