Add SECURITY.md and report RCE issue#17
Open
michaelpierre wants to merge 1 commit intoDreamLM:mainfrom
Open
Conversation
This commit adds a SECURITY.md file and also documents a discovered vulnerability in the way the repo loads external Hugging Face models. The demo scripts use `trust_remote_code=True` without validation, which allows for remote code execution (RCE) when a user supplies a malicious model path. The vulnerability is not disclosed publicly, and the model repository used for testing has been made private to prevent abuse. Please refer to the pull request body for full details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a SECURITY.md file for responsible disclosure.
In the process of reviewing the project, I identified a critical vulnerability (Remote Code Execution) in several demo scripts.
I have not made any details public, but I’m happy to provide a private proof-of-concept to the maintainers via email or secure message.
Let me know how you’d like to proceed.