fix: Allow non-static CustomHandler method if scan method is non-static #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a restriction that prevented non-static CustomHandler methods from being used in service registration generation. The change allows instance methods to be used as CustomHandler when the scan method itself is non-static.
- Updates diagnostic message to remove the "static" requirement for CustomHandler methods
- Removes the static method constraint when searching for CustomHandler methods
- Adds test coverage for using instance CustomHandler methods
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DiagnosticDescriptors.cs | Updates error message to remove static requirement |
| DependencyInjectionGenerator.ParseMethodModel.cs | Removes static constraint from CustomHandler method lookup |
| CustomHandlerTests.cs | Adds test for instance CustomHandler method functionality |
ServiceScan.SourceGenerator/DependencyInjectionGenerator.ParseMethodModel.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.