Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts TTS engine initialization order so model selection (language/sub/model_path) is resolved before calling load_engine() (and _load_engine_zs() where applicable), and centralizes model_path computation in __init__ for Bark/Fairseq.
Changes:
- Move
load_engine()/_load_engine_zs()calls to occur aftermodel_path(and samplerate/sub) are determined for Vits/Tortoise/Tacotron/GlowTTS. - Compute and store
self.model_pathduring__init__for Fairseq and Bark, and use it fromload_engine(). - Update Fairseq to set
self.tts_keyfromself.model_pathprior to_load_api().
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/classes/tts_engines/vits.py | Load engine(s) after model_path and samplerate are derived from language/sub selection. |
| lib/classes/tts_engines/tortoise.py | Load engine after model_path and samplerate are derived from language/sub selection. |
| lib/classes/tts_engines/tacotron.py | Load engine(s) after model_path and samplerate are derived from language/sub selection. |
| lib/classes/tts_engines/glowtts.py | Load engine(s) after model_path and samplerate are derived from language/sub selection. |
| lib/classes/tts_engines/fairseq.py | Move model_path computation into __init__ and use it in load_engine(). |
| lib/classes/tts_engines/bark.py | Move model_path computation into __init__ and use it in load_engine(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.