Skip to content

v26.2.26#1645

Merged
ROBERT-MCDOWELL merged 3 commits intomainfrom
v26
Feb 26, 2026
Merged

v26.2.26#1645
ROBERT-MCDOWELL merged 3 commits intomainfrom
v26

Conversation

@ROBERT-MCDOWELL
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings February 26, 2026 04:21
@ROBERT-MCDOWELL ROBERT-MCDOWELL merged commit 4ac5f00 into main Feb 26, 2026
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts TTS engine initialization order so model selection (language/sub/model_path) is resolved before calling load_engine() (and _load_engine_zs() where applicable), and centralizes model_path computation in __init__ for Bark/Fairseq.

Changes:

  • Move load_engine() / _load_engine_zs() calls to occur after model_path (and samplerate/sub) are determined for Vits/Tortoise/Tacotron/GlowTTS.
  • Compute and store self.model_path during __init__ for Fairseq and Bark, and use it from load_engine().
  • Update Fairseq to set self.tts_key from self.model_path prior to _load_api().

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
lib/classes/tts_engines/vits.py Load engine(s) after model_path and samplerate are derived from language/sub selection.
lib/classes/tts_engines/tortoise.py Load engine after model_path and samplerate are derived from language/sub selection.
lib/classes/tts_engines/tacotron.py Load engine(s) after model_path and samplerate are derived from language/sub selection.
lib/classes/tts_engines/glowtts.py Load engine(s) after model_path and samplerate are derived from language/sub selection.
lib/classes/tts_engines/fairseq.py Move model_path computation into __init__ and use it in load_engine().
lib/classes/tts_engines/bark.py Move model_path computation into __init__ and use it in load_engine().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants