Skip to content

Fix compile errors on kernels with backported linux/nvme_ioctl.h#174

Open
pmorici wants to merge 1 commit intoDrive-Trust-Alliance:masterfrom
pmorici:master
Open

Fix compile errors on kernels with backported linux/nvme_ioctl.h#174
pmorici wants to merge 1 commit intoDrive-Trust-Alliance:masterfrom
pmorici:master

Conversation

@pmorici
Copy link

@pmorici pmorici commented Oct 12, 2017

This change fixes compile errors on CentOS 7, RHEL 7, and other distributions have have back ported the nvme_ioctl.h change. Instead of checking the kernel version this change checks for the existence of the nvme include file with autoconf.

@yaplej
Copy link

yaplej commented Feb 5, 2018

Any chance this will get merged soon?

@pmorici
Copy link
Author

pmorici commented Feb 6, 2018

No one has even contacted me asking for a signed contributor agreement so I'm gonna guess no.

@r0m30
Copy link
Contributor

r0m30 commented Apr 27, 2018

The building and testing of sedutil is done primarily using the Eclipse IDE which does not use autoconf et al. The autoconf files included in the source tree are there for use in the PBA build process and as a courtesy to the distribution packagers. They expect the kernel supplied by kernel.org as input.

It was a goal to get the build to use autoconf but there has been no progress towards this to date.

@pmorici
Copy link
Author

pmorici commented Apr 28, 2018

@r0m30 I'm confused, what do you mean there has been no progress toward using autoconf to build?

With the application of this patch sedutil builds fine with autoconf. I do the following steps to build with autoconf on Linux. At any rate this patch doesn't break building the PBA from the vanilla kernel and would encourage you to merge it.

autoreconf -i
./configure
make

@r0m30
Copy link
Contributor

r0m30 commented May 4, 2018

@pmorici it will break the Eclipse build that I use during development.
I wasn't saying that your patch was broken, I was saying that it breaks my dev environment. Eclipse uses custom makefiles not autoconf and I haven't had the time convert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants