Skip to content

Support HGST SSD400M SAS drives #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pruiz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support HGST SSD400M SAS drives #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d098fcc
Fixes issue 200: scaning does not work with SAS (TCG/Enterprise) drives.
invalid-email-address Jun 10, 2018
0e383ac
Add support for HGST SSD400M drives (sometimes rebranded by IBM) whic…
pruiz Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions Common/DtaDev.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,10 @@ void DtaDev::discovery0()
uint8_t lastRC;
void * d0Response = NULL;
uint8_t * epos, *cpos;
size_t length;
Discovery0Header * hdr;
Discovery0Features * body;

d0Response = discovery0buffer + IO_BUFFER_ALIGNMENT;
d0Response = (void *)((uintptr_t)d0Response & (uintptr_t)~(IO_BUFFER_ALIGNMENT - 1));
memset(d0Response, 0, MIN_BUFFER_LENGTH);
Expand All @@ -124,13 +126,28 @@ void DtaDev::discovery0()

epos = cpos = (uint8_t *) d0Response;
hdr = (Discovery0Header *) d0Response;
length = SWAP32(hdr->length);

// HACK: Some non-standard IBM-Rebranded HGST drives
// incorrectly return hdr->length as the length
// of the features descriptors, not including
// discovery header length itself.
// We detect this case when length is reported as
// less bytes than those needed by discovery0 header
// on it's own.. (pruiz)
if (length <= 44)
{
length = 48 + length;
}

LOG(D3) << "Dumping D0Response";
IFLOG(D3) DtaHexDump(hdr, SWAP32(hdr->length));
epos = epos + SWAP32(hdr->length);
IFLOG(D3) DtaHexDump(hdr, length);
epos = epos + length;
cpos = cpos + 48; // TODO: check header version

do {
body = (Discovery0Features *) cpos;
LOG(D1) << "Parsing features of kind: " << std::hex << SWAP16(body->TPer.featureCode) << std::dec;
switch (SWAP16(body->TPer.featureCode)) { /* could use of the structures here is a common field */
case FC_TPER: /* TPer */
disk_info.TPer = 1;
Expand All @@ -140,6 +157,7 @@ void DtaDev::discovery0()
disk_info.TPer_comIDMgt = body->TPer.comIDManagement;
disk_info.TPer_streaming = body->TPer.streaming;
disk_info.TPer_sync = body->TPer.sync;
disk_info.ANY_OPAL_SSC = 1; // Having TPer feature already means this is an TCG/SSC drive.
break;
case FC_LOCKING: /* Locking*/
disk_info.Locking = 1;
Expand Down Expand Up @@ -196,6 +214,7 @@ void DtaDev::discovery0()
break;
default:
if (0xbfff < (SWAP16(body->TPer.featureCode))) {
LOG(D1) << "Vendor specific: " << std::hex << SWAP16(body->TPer.featureCode) << std::dec;
// silently ignore vendor specific segments as there is no public doc on them
disk_info.VendorSpecific += 1;
}
Expand Down
3 changes: 3 additions & 0 deletions linux/DtaDevLinuxSata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ void DtaDevLinuxSata::identify(OPAL_DiskInfo& disk_info)

if (!(memcmp(nullz.data(), buffer, 512))) {
disk_info.devType = DEVICE_TYPE_OTHER;
// XXX: ioctl call was aborted or returned no data, most probably
// due to driver not being libata based, let's try SAS instead.
identify_SAS(&disk_info);
return;
}
IDENTIFY_RESPONSE * id = (IDENTIFY_RESPONSE *) buffer;
Expand Down