Show TimeLane even if the visibleItemsInfo is empty#904
Open
mochico wants to merge 4 commits intoDroidKaigi:mainfrom
Open
Show TimeLane even if the visibleItemsInfo is empty#904mochico wants to merge 4 commits intoDroidKaigi:mainfrom
mochico wants to merge 4 commits intoDroidKaigi:mainfrom
Conversation
mochico
commented
Oct 11, 2022
| } | ||
| var currentDurationTime: DurationTime? = null | ||
|
|
||
| if (visibleItemsInfo.value.isEmpty()) { |
Author
There was a problem hiding this comment.
For reviewer:
The original cause of missing TimeLane in the preview was: the preview is a preview, and the scroll does not happen, so visibleItemsInfo is empty.
This should fix the original problem of missing TimeLane in the Preview screenshot tests and should not break the product but it is open to the argument if we have to put the code for the test. If you think it better to avoid placing the code for testing, you'd better update the expected screenshot in the test.
|
There are differences in Compose previews: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot
Special thanks for the investigation
@offwhiite @sobaya-0141