[Android] sticky title on TimetableGrid#1262
Open
ked4ma wants to merge 4 commits intoDroidKaigi:mainfrom
Open
Conversation
ked4ma
commented
Sep 16, 2023
Comment on lines
+117
to
+121
| var displayedPosition by remember { mutableFloatStateOf(0f) } | ||
| var itemHeight by remember { mutableIntStateOf(0) } | ||
| var titleHeight by remember { mutableIntStateOf(0) } | ||
| var timeHeight by remember { mutableIntStateOf(0) } | ||
| var speakerHeight by remember { mutableIntStateOf(0) } |
Contributor
Author
There was a problem hiding this comment.
theere are possibility that height of column composable for title, time speaker have a variety of values according to session name.
And it was difficult to use spacer to get a room of item (due to weight and so on).
so here, getting each height and calculating maxOffset from these values.
github-actions
bot
temporarily deployed
to
deploygate-distribution
ked4ma
changed the title
Member
|
@ked4ma Could you add a screenshot test to check it? 🙏 |
Contributor
Author
|
sure. |
|
Hi @ked4ma! Codes seem to be unformatted. To resolve this issue, please run |
|
Snapshot diff report
|
ked4ma
commented
Sep 17, 2023
| startY = visibleSize.height * 4F / 5, | ||
| endY = visibleSize.height / 2F, | ||
| startY = visibleSize.height * startRatio, | ||
| endY = visibleSize.height * (startRatio - amount), |
Contributor
Author
There was a problem hiding this comment.
enabled to pass a parameter for scrolling amount. (for this pr)
github-actions
bot
temporarily deployed
to
deploygate-distribution
github-actions
bot
temporarily deployed
to
deploygate-distribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot (Optional if screenshot test is present or unrelated to UI)
Movie (Optional)
Screen_recording_20230916_190405.webm
Screen_recording_20230916_190338.webm
Screen_recording_20230916_190046.webm
Screen_recording_20230916_190227.webm