Improve timetable talkback feedback by NUmeroAndDev · Pull Request #609 · DroidKaigi/conference-app-2025

NUmeroAndDev · 2025-09-08T12:52:24Z

Issue

Let's try enhancing TalkBack support. (Enhanced accessibility.) #506

Overview (Required)

I resolved todo comment marked at [Proposal]More material expressive #525.
Improved the navigation of Talkback in the Timetable list for Custom actions.
Grouped time display and improved focus with Talkback.

Links

https://developer.android.com/develop/ui/compose/accessibility/semantics#custom-actions

Screenshot (Optional if screenshot test is present or unrelated to UI)

Before	After

Movie (Optional)

Before	After
Screen_recording_20250908_215143.mp4	Screen_recording_20250908_215036.mp4

NUmeroAndDev · 2025-09-08T13:39:13Z

core/droidkaigiui/src/commonMain/composeResources/values-ja/strings.xml

    <string name="error_occurred">エラー...</string>
    <string name="retry">再試行</string>
+    <string name="add_to_bookmark">ブックマークに登録</string>
+    <string name="remove_from_bookmark">ブックマークを削除</string>


The same wording is found here, Would it be better to make it publicResClass = false and make it common?

conference-app-2025/feature/sessions/src/commonMain/composeResources/values-ja/strings.xml

Lines 40 to 41 in 3aace3d

<string name="add_to_bookmark">ブックマークに登録</string>

<string name="remove_from_bookmark">ブックマークを削除</string>

Yes, that sounds like a good idea. Could you please make it common?

I tried to implemented at 50ec935 .
Could you please check this? 🙏

Copilot

Pull Request Overview

This PR improves accessibility support for TalkBack users in the timetable screen by implementing custom accessibility actions for bookmark functionality and enhancing time slot navigation.

Replaced direct bookmark button clicks with custom accessibility actions for better screen reader support
Added semantic grouping for time display elements with clear heading indicators
Updated string resources to provide more descriptive bookmark action labels

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
FavoritesScreenRobot.kt	Updated test to use custom accessibility action instead of direct button click
TimetableItemCard.kt	Added custom accessibility actions for bookmark functionality and cleared button semantics
TimetableTimeSlot.kt	Enhanced time slot accessibility with semantic grouping and heading indicators
strings.xml (English)	Replaced generic bookmark status strings with action-oriented labels
strings.xml (Japanese)	Updated Japanese translations for bookmark actions

Copilot · 2025-09-08T13:40:31Z

...c/commonMain/kotlin/io/github/droidkaigi/confsched/droidkaigiui/session/TimetableItemCard.kt

+import io.github.droidkaigi.confsched.droidkaigiui.add_to_bookmark
 import io.github.droidkaigi.confsched.droidkaigiui.component.OutlinedToolTip
 import io.github.droidkaigi.confsched.droidkaigiui.component.RoomToolTip
 import io.github.droidkaigi.confsched.droidkaigiui.extension.icon
 import io.github.droidkaigi.confsched.droidkaigiui.extension.roomTheme
-import io.github.droidkaigi.confsched.droidkaigiui.not_bookmarked
+import io.github.droidkaigi.confsched.droidkaigiui.remove_from_bookmark


The import statements reference string resources incorrectly. String resources should be accessed via DroidkaigiuiRes.string.add_to_bookmark and DroidkaigiuiRes.string.remove_from_bookmark, not as direct imports.

Copilot · 2025-09-08T13:40:31Z

...c/commonMain/kotlin/io/github/droidkaigi/confsched/droidkaigiui/session/TimetableItemCard.kt

 import io.github.droidkaigi.confsched.droidkaigiui.extension.icon
 import io.github.droidkaigi.confsched.droidkaigiui.extension.roomTheme
-import io.github.droidkaigi.confsched.droidkaigiui.not_bookmarked
+import io.github.droidkaigi.confsched.droidkaigiui.remove_from_bookmark


The import statements reference string resources incorrectly. String resources should be accessed via DroidkaigiuiRes.string.add_to_bookmark and DroidkaigiuiRes.string.remove_from_bookmark, not as direct imports.

Copilot · 2025-09-08T13:40:31Z

...onMain/kotlin/io/github/droidkaigi/confsched/testing/robot/favorites/FavoritesScreenRobot.kt

+        composeUiTest.onAllNodes(hasTestTag(TimetableItemCardTestTag))
            .onFirst()
-            .performClick()
+            .performCustomAccessibilityActionWithLabel("Remove from Bookmarks")


The hardcoded string 'Remove from Bookmarks' should be extracted to a constant or use the same string resource to ensure consistency with the UI labels and support for localization.

kilalabu

Thank you for your contribution and for focusing on accessibility!

kilalabu · 2025-09-09T12:09:42Z

core/droidkaigiui/src/commonMain/composeResources/values-ja/strings.xml

    <string name="error_occurred">エラー...</string>
    <string name="retry">再試行</string>
+    <string name="add_to_bookmark">ブックマークに登録</string>
+    <string name="remove_from_bookmark">ブックマークを削除</string>


Yes, that sounds like a good idea. Could you please make it common?

github-actions · 2025-09-09T12:57:31Z

Snapshot diff report

File name	Image
TimetableScreenPrevi ew_Grid_compare.png

NUmeroAndDev · 2025-09-09T13:07:41Z

There's a similar diff here. 🤔

kilalabu

Looks nice. Thank you !!

NUmeroAndDev added 5 commits September 8, 2025 21:17

Fixed favorite icon button description

69b8fea

Moved favorite action to custom action

44a5ead

Improve the description of time and set as heading

b9b5591

Applied code format

5e8b631

Fixed screen test

89cc255

NUmeroAndDev commented Sep 8, 2025

View reviewed changes

NUmeroAndDev marked this pull request as ready for review September 8, 2025 13:39

Copilot AI review requested due to automatic review settings September 8, 2025 13:39

NUmeroAndDev requested a review from a team as a code owner September 8, 2025 13:39

NUmeroAndDev requested review from kilalabu and removed request for a team September 8, 2025 13:39

Copilot AI reviewed Sep 8, 2025

View reviewed changes

NUmeroAndDev changed the title ~~Improve timetable talkback response~~ Improve timetable talkback feedback Sep 9, 2025

kilalabu reviewed Sep 9, 2025

View reviewed changes

Shared the string resources

50ec935

NUmeroAndDev requested a review from kilalabu September 9, 2025 12:56

kilalabu approved these changes Sep 9, 2025

View reviewed changes

kilalabu added this pull request to the merge queue Sep 9, 2025

Merged via the queue into DroidKaigi:main with commit f697460 Sep 9, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve timetable talkback feedback#609

Improve timetable talkback feedback#609
kilalabu merged 6 commits intoDroidKaigi:mainfrom
NUmeroAndDev:improve_timetable_talkback_response

NUmeroAndDev commented Sep 8, 2025 •

edited

Loading

Uh oh!

NUmeroAndDev Sep 8, 2025

Uh oh!

kilalabu Sep 9, 2025

Uh oh!

NUmeroAndDev Sep 9, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

Copilot AI Sep 8, 2025

Uh oh!

kilalabu left a comment

Uh oh!

kilalabu Sep 9, 2025

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

NUmeroAndDev commented Sep 9, 2025

Uh oh!

kilalabu left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<string name="add_to_bookmark">ブックマークに登録</string>
	<string name="remove_from_bookmark">ブックマークを削除</string>

Conversation

NUmeroAndDev commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Overview (Required)

Links

Screenshot (Optional if screenshot test is present or unrelated to UI)

Movie (Optional)

Uh oh!

NUmeroAndDev Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

kilalabu Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

NUmeroAndDev Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

kilalabu left a comment

Choose a reason for hiding this comment

Uh oh!

kilalabu Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 9, 2025

Uh oh!

NUmeroAndDev commented Sep 9, 2025

Uh oh!

kilalabu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NUmeroAndDev commented Sep 8, 2025 •

edited

Loading