test: add ProfileProvider tests#652
Open
daichikuwa0618 wants to merge 1 commit intoDroidKaigi:mainfrom
Open
Conversation
daichikuwa0618
requested review from
Copilot and
ry-itto
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive unit tests for the ProfileProvider class, introducing TestClock for deterministic async testing and ensuring proper test isolation.
Key Changes
- Adds unit tests covering all ProfileProvider functionality including subscription, loading states, profile updates, and save operations
- Introduces TestClock for reliable async testing with deterministic time control
- Implements @suite(.serialized) annotation to prevent race conditions between tests
app-ios/Core/Tests/PresentationTests/ProfileProviderTests.swift
Outdated
Show resolved
Hide resolved
daichikuwa0618
force-pushed
the
feature/ISSUE-355-profile-provider-test
branch
from
a98b8f2 to
8a02e98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
TestClockto handle complex async timing:ProfileProviderhas intricate async flows with multiple state updates, making traditional async testing unstable.TestClockprovides deterministic control over time advancement, ensuring reliable and reproducible test results@Suite(.serialized)annotation to ensure test isolation and prevent race conditionsLinks