Stop inheriting from Exporter#27
Merged
marekro merged 1 commit intoDual-Life:masterfrom Mar 29, 2025
ap-contrib:master
Merged
Conversation
|
@marekro, can you take a look at this and, if satisfactory, issue a new CPAN release? This is one of the few cases where we have a module that ships with Perl that we could still squeeze in to Perl-5.42.0, so we'd like to get this reviewed. Thank you very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #17, it is only necessary to do either
use Exporter 'import'or some form ofpush @ISA, 'Exporter'. Doing both is redundant, and the former is preferred, so this patch takes the latter back out.