Open
Conversation
Closed
jakirkham
force-pushed
the
gh-pages
branch
5 times, most recently
from
76b23b9 to
e45e06e
Compare
Member
Author
|
I'm pretty sure I'm still off on some things here, but maybe it is a good time for a review. Also, feel free to make comments on the diff if there are particular lines that are off or wrong. This actually makes it pretty easy to keep track of what has and hasn't been done. |
Member
Author
|
Any thoughts on this, @dudmanj? Would really love to check this one off the list. |
|
it'd be good to add a AP, ML, and Z value for the electrode, as well as type of electrode used (first 3 are floats, last one is string) |
jakirkham
commented
Jul 26, 2017
| </label> | ||
| <br> | ||
| <label>Laser Power : | ||
| <input type="number" step="any" value=0 name="LaserPower" id="LaserPower" placeholder="LaserPower" /> |
Member
Author
There was a problem hiding this comment.
Should specify this is milliwatts.
jakirkham
commented
Jul 26, 2017
| <br> | ||
| <label>Laser Power : | ||
| <input type="number" step="any" value=0 name="LaserPower" id="LaserPower" placeholder="LaserPower" /> | ||
| </label> |
Member
Author
There was a problem hiding this comment.
Could be handy to have a notes section for miscellaneous info about how the recording is done.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a simple webform that one can fill out online and download a JSON config file from. To see a live demo, please follow this link.