Conversation
Changed relative Swagger endpoint paths to absolute ones for consistency and to prevent potential issues with path resolution. This ensures the Swagger UI functions correctly in all deployment environments.
Refactor logic to dynamically add authentication buttons only when not already present. Introduce a more reliable method to detect and handle the rendering of the Swagger UI elements using MutationObserver with additional safeguards. This ensures improved performance and stability in handling authentication states.
khalidabuhakmeh
approved these changes
Mar 24, 2025
Collaborator
khalidabuhakmeh
left a comment
khalidabuhakmeh
left a comment
There was a problem hiding this comment.
@Erwinvandervalk It looks good. I made two fixes:
- The JavaScript now works across service changes (need to revisit in the future with Swagger plugins)
- Fixed double registration of API1 in the dropdown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sample for how to use the BFF with OpenAPI: