WiFi OM update from NetworkStatusResponse#592
Open
rechrtb wants to merge 2 commits intoDuet3D:3.5-devfrom
Open
WiFi OM update from NetworkStatusResponse#592rechrtb wants to merge 2 commits intoDuet3D:3.5-devfrom
rechrtb wants to merge 2 commits intoDuet3D:3.5-devfrom
Conversation
rechrtb
force-pushed
the
add_wifi_om
branch
6 times, most recently
from
9aaaa68 to
5af5522
Compare
rechrtb
changed the title
dc42
reviewed
Nov 20, 2022
Collaborator
dc42
left a comment
dc42
left a comment
There was a problem hiding this comment.
Looks good to me. Does the additional status polling affect the file upload speed?
Contributor
Author
|
Hi @dc42, there doesn't seem to be an appreciable difference. |
Contributor
Author
|
@dc42 What do you think about parsing and storing major and minor version number as done here: 67328fe Gives me the option of using the padding fields in the struct, and if there is issue there is a visible error message at the start (might even opt to re-disable the module instead of just displaying the error message). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure that the fields needed for the OM are updated from NetworkStatusResponse.
Related to: Duet3D/WiFiSocketServerRTOS#41.