Chore/aula 2308 headers injector#2
Open
kittyradulescu wants to merge 12 commits intoDurgaprasad-Budhwani:masterfrom
Open
Chore/aula 2308 headers injector#2kittyradulescu wants to merge 12 commits intoDurgaprasad-Budhwani:masterfrom
kittyradulescu wants to merge 12 commits intoDurgaprasad-Budhwani:masterfrom
Conversation
…which was not allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Context
We have deprecated the
security-headers-configservice a while back. This service was responsible for adding the headers and I found the code in graveyard. At that time when we deprecated the service we might have not wanted to include the headers so we removed the service as we were not using it. Once we restore the service in all the institutions and re-deploy the web applications on all the institutions we'll have the headers in on the web-app.The function name was exceeding 64 characters that prevented deployment to environments so I changed the name of the function to contain less characters.
${institution}-security-headers-injector-prod-injectSecurityHeaders, to${institution}-security-headers-injector-prod-injectHeaders.Code in graveyard
Documentation in Notion where it is explained how the headers are used can be found here:
Security headers in Notion
Changelog
Loom/Screenshot
Not needed.
Review Guideline Cheatsheet
:cake::bulb::thinking::hammer::rocket: