Skip to content

Chore/aula 2308 headers injector#2

Open
kittyradulescu wants to merge 12 commits intoDurgaprasad-Budhwani:masterfrom
AulaEducation:chore/AULA-2308-headers-injector
Open

Chore/aula 2308 headers injector#2
kittyradulescu wants to merge 12 commits intoDurgaprasad-Budhwani:masterfrom
AulaEducation:chore/AULA-2308-headers-injector

Conversation

@kittyradulescu
Copy link

Technical Context

We have deprecated the security-headers-config service a while back. This service was responsible for adding the headers and I found the code in graveyard. At that time when we deprecated the service we might have not wanted to include the headers so we removed the service as we were not using it. Once we restore the service in all the institutions and re-deploy the web applications on all the institutions we'll have the headers in on the web-app.

The function name was exceeding 64 characters that prevented deployment to environments so I changed the name of the function to contain less characters.

${institution}-security-headers-injector-prod-injectSecurityHeaders, to ${institution}-security-headers-injector-prod-injectHeaders.

Code in graveyard

Documentation in Notion where it is explained how the headers are used can be found here:
Security headers in Notion

Changelog

- Chore | Restored the security-headers-config and upgraded to use Node 18.

Loom/Screenshot

Not needed.

Review Guideline Cheatsheet

Please refer to this doc for the complete PR review guideline.

Emoji Intention
🍰 :cake: Nice to have, but not blocking
💡 :bulb: Refactor suggestion or another idea that require relevant changes and may need a discussion
🤔 :thinking: Something is not clear, can you give me more context?
🔨 :hammer: Required change
🚀 :rocket: Positive feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants