Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@
]
},
"dependencies": {
"@elastic/elasticsearch": "8.13.1",
"@elastic/elasticsearch": "8.14.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

As noted in the pull request description, package-lock.json has not been updated. To ensure the security vulnerability is actually fixed, please run npm install to update the lock file and commit the changes. Without this, the old, vulnerable version of the dependency might still be used.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While reviewing this dependency upgrade, I noticed that we are using deep imports for types from this package (e.g., from '@elastic/elasticsearch/lib/api/types'). This is a fragile practice as internal paths can change without notice even in minor versions, which could break the build. It's recommended to refactor these imports to use the public API of the package for better long-term maintainability.

"@github/failbot": "0.8.3",
"@horizon-rs/language-guesser": "0.1.1",
"@octokit/plugin-retry": "7.1.2",
Expand Down