Skip to content

npm(deps-dev): bump syncpack from 13.0.4 to 14.0.0 in the version-management group #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Feb 24, 2026
Merged

npm(deps-dev): bump syncpack from 13.0.4 to 14.0.0 in the version-management group #805

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d474f15
npm(deps-dev): bump syncpack in the version-management group
dependabot[bot] Feb 21, 2026
7e55a0e
fix(syncpack): updated code to be compatible with version 14
Dwlad90 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/sync-deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:

- name: Sync dependencies
run: |
pnpm syncpack fix-mismatches --source "**/package.json"
pnpm syncpack fix

- name: Commit changes if needed
run: |
Expand All @@ -57,9 +57,9 @@ jobs:
fi

- name: Comment on PR
if: steps.commit-changes.outputs.changes_pushed == 'true' # Only run if changes were pushed
if: steps.commit-changes.outputs.changes_pushed == 'true' # Only run if changes were pushed
run: |
gh pr comment ${{ github.event.pull_request.number }} --body "I've synchronized dependencies across the workspace to ensure consistency."
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
26 changes: 15 additions & 11 deletions .syncpackrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
{
"dependencyTypes": [
"dev",
"prod",
"resolutions",
"overrides",
"pnpmOverrides"
],
"filter": ".",
"$schema": "./node_modules/syncpack/schema.json",
"indent": " ",
"semverGroups": [],
"semverRange": "",
"sortAz": [
"contributors",
"private",
Expand Down Expand Up @@ -43,7 +35,19 @@
],
"source": [
"package.json",
"pkgs/*/package.json"
"*/*/package.json"
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source pattern was changed from "pkgs//package.json" to "//package.json". The old pattern "pkgs/" doesn't match the actual directory structure (which uses "packages/" and "apps/"), so this change appears to be a fix. However, the new pattern "//package.json" will match two levels deep from root, which correctly matches packages//package.json and apps//package.json, but it will also match any other two-level deep package.json files.

Consider being more explicit with the pattern to avoid accidentally including unwanted package.json files:
"source": [
"package.json",
"packages//package.json",
"apps//package.json"
]

This makes the intent clearer and prevents accidental inclusion of other package.json files that might exist at the same depth.

Suggested change
"*/*/package.json"
"packages/*/package.json",
"apps/*/package.json"

Copilot uses AI. Check for mistakes.
],
"versionGroups": []
"versionGroups": [
{
"label": "Accept everything except peerDependencies",
"dependencyTypes": [
"!dev",
"!prod",
"!resolutions",
"!overrides",
"!pnpmOverrides"
Comment on lines +44 to +48
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The versionGroups configuration appears to have inverted logic. The label says "Accept everything except peerDependencies", but the implementation uses negation operators (!) on dev, prod, resolutions, overrides, and pnpmOverrides, which means it's actually selecting ONLY peerDependencies. Then it sets isIgnored: true on those peerDependencies.

Based on the label's intent, the configuration should likely be:

  • Remove the negation operators (!) to select dev, prod, resolutions, overrides, pnpmOverrides
  • OR add "peer" to the list with negation to exclude it: "!peer"

This needs to be corrected to match the intended behavior. You can verify the correct syntax in the syncpack v14 migration guide.

Suggested change
"!dev",
"!prod",
"!resolutions",
"!overrides",
"!pnpmOverrides"
"dev",
"prod",
"resolutions",
"overrides",
"pnpmOverrides"

Copilot uses AI. Check for mistakes.
],
"isIgnored": true
}
]
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"lint-staged": "^16.2.7",
"prettier": "^3.8.1",
"shellcheck": "^4.1.0",
"syncpack": "^13.0.4",
"syncpack": "^14.0.0",
"turbo": "^2.8.10",
Comment on lines 40 to 42
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description indicates this is only a devDependency bump for syncpack, but the diff also includes broad dependency range rewrites (notably multiple published packages' peerDependencies). If those range changes are intentional, please document the intended compatibility/support policy in the PR description (or split them into a separate PR) so reviewers can assess the breaking-change impact separately from the tooling upgrade.

Copilot uses AI. Check for mistakes.
"typescript": "^5.9.3"
},
Expand Down
22 changes: 11 additions & 11 deletions packages/nextjs-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,26 @@
"private": false,
"license": "MIT",
"sideEffects": false,
"files": [
"dist"
],
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
},
"exports": {
"./turbopack": {
"types": "./dist/turbopack.d.ts",
"import": "./dist/turbopack.js",
"require": "./dist/turbopack.js",
"types": "./dist/turbopack.d.ts"
"require": "./dist/turbopack.js"
},
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.js",
"types": "./dist/index.d.ts"
"require": "./dist/index.js"
},
"./package.json": "./package.json"
},
"files": [
"dist"
],
"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
},
"scripts": {
"build": "scripty --ts",
"check:artifacts": "scripty",
Expand Down
Loading
Loading